Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1029103003: Revert of Instrumented libraries: add a target for pre-built libraries. (Closed)

Created:
5 years, 9 months ago by earthdok
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Instrumented libraries: add a target for pre-built libraries. (patchset #2 id:20001 of https://codereview.chromium.org/1017053003/) Reason for revert: Broke tree. Original issue's description: > Instrumented libraries: add a target for pre-built libraries. > > With use_prebuilt_instrumented_libraries=1 in GYP_DEFINES, binaries are now > unpacked from archive and placed into output dir. > > BUG=462636 > R=glider@chromium.org > TBR=thakis@chromium.org > NOTRY=true > > Committed: https://crrev.com/744256e2f3933feaa05c967541afac36825056fa > Cr-Commit-Position: refs/heads/master@{#321804} TBR=glider@chromium.org,thakis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=462636 Committed: https://crrev.com/6b777d77c3e23bf7ccf8f4fe2aa47874a435c631 Cr-Commit-Position: refs/heads/master@{#321806}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -74 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/instrumented_libraries/instrumented_libraries.gyp View 2 chunks +1 line, -54 lines 0 comments Download
D third_party/instrumented_libraries/scripts/unpack_binaries.sh View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
earthdok
Created Revert of Instrumented libraries: add a target for pre-built libraries.
5 years, 9 months ago (2015-03-23 17:55:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029103003/1
5 years, 9 months ago (2015-03-23 17:55:30 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-23 17:56:34 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 17:57:06 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6b777d77c3e23bf7ccf8f4fe2aa47874a435c631
Cr-Commit-Position: refs/heads/master@{#321806}

Powered by Google App Engine
This is Rietveld 408576698