Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1017053003: Instrumented libraries: add a target for pre-built libraries. (Closed)

Created:
5 years, 9 months ago by earthdok
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Instrumented libraries: add a target for pre-built libraries. With use_prebuilt_instrumented_libraries=1 in GYP_DEFINES, binaries are now unpacked from archive and placed into output dir. BUG=462636 R=glider@chromium.org TBR=thakis@chromium.org NOTRY=true Committed: https://crrev.com/744256e2f3933feaa05c967541afac36825056fa Cr-Commit-Position: refs/heads/master@{#321804}

Patch Set 1 #

Patch Set 2 : script #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -1 line) Patch
M build/common.gypi View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/instrumented_libraries/instrumented_libraries.gyp View 2 chunks +54 lines, -1 line 0 comments Download
A third_party/instrumented_libraries/scripts/unpack_binaries.sh View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
earthdok
Please take a look: Alex - general review Nico - ownership and possibly general review
5 years, 9 months ago (2015-03-18 21:50:42 UTC) #2
earthdok
On 2015/03/18 21:50:42, earthdok wrote: > Please take a look: > > Alex - general ...
5 years, 9 months ago (2015-03-18 21:53:40 UTC) #3
Nico
lgtm once glider is happy
5 years, 9 months ago (2015-03-20 17:35:39 UTC) #4
Nico
lgtm once glider is happy
5 years, 9 months ago (2015-03-20 17:35:40 UTC) #5
Alexander Potapenko
I am. LGTM
5 years, 9 months ago (2015-03-23 12:43:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1017053003/20001
5 years, 9 months ago (2015-03-23 17:49:33 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-23 17:50:17 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/744256e2f3933feaa05c967541afac36825056fa Cr-Commit-Position: refs/heads/master@{#321804}
5 years, 9 months ago (2015-03-23 17:51:18 UTC) #10
earthdok
5 years, 9 months ago (2015-03-23 17:55:07 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1029103003/ by earthdok@chromium.org.

The reason for reverting is: Broke tree..

Powered by Google App Engine
This is Rietveld 408576698