Implementing ATK functions get_index_in_parent & ref_relation_set for Chrome UI

Implementing ATK functions get_index_in_parent & ref_relation_set for Chrome UI

BUG=463671
Committed: https://crrev.com/7d5426fdb05ade9631fa3d9d0fe6135b272eb147
Cr-Commit-Position: refs/heads/master@{#321929}

[shreeramk, 2015-03-23 12:17:53]

shreeram.k@samsung.com changed reviewers:
+ dmazzoni@chromium.org, dtseng@chromium.org

[shreeramk, 2015-03-23 12:17:53]

PTAL. Thanks!

[dmazzoni, 2015-03-23 22:19:57]

lgtm

https://codereview.chromium.org/1029043002/diff/1/ui/accessibility/platform/a...
File ui/accessibility/platform/ax_platform_node_auralinux.cc (right):

https://codereview.chromium.org/1029043002/diff/1/ui/accessibility/platform/a...
ui/accessibility/platform/ax_platform_node_auralinux.cc:91: 
nit: get rid of this blank line at the beginning of the function

https://codereview.chromium.org/1029043002/diff/1/ui/accessibility/platform/a...
ui/accessibility/platform/ax_platform_node_auralinux.cc:103: bool
atk_object_found = (child == atk_object)?true:false;
nit: git rid of "?true:false", it's not needed

https://codereview.chromium.org/1029043002/diff/1/ui/accessibility/platform/a...
ui/accessibility/platform/ax_platform_node_auralinux.cc:104:
g_object_unref(child);
in a separate changelist, could you look into the possibility of writing a
wrapper class like scoped_gobject? (similar to ScopedComPtr or scoped_ptr).

https://codereview.chromium.org/1029043002/diff/1/ui/accessibility/platform/a...
ui/accessibility/platform/ax_platform_node_auralinux.cc:359: return;
nit: no "return", just leave it blank.

https://codereview.chromium.org/1029043002/diff/1/ui/accessibility/platform/a...
File ui/accessibility/platform/ax_platform_node_auralinux.h (right):

https://codereview.chromium.org/1029043002/diff/1/ui/accessibility/platform/a...
ui/accessibility/platform/ax_platform_node_auralinux.h:27: void
GetAtkRelation(AtkRelationSet* atk_relation_set);
I'd call this GetAtkRelations

[shreeramk, 2015-03-24 03:02:51]

The CQ bit was checked by shreeram.k@samsung.com

[shreeramk, 2015-03-24 03:02:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/1029043002/#ps40001
(title: "fixing one more nit")

[commit-bot: I haz the power, 2015-03-24 03:03:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1029043002/40001

[shreeramk, 2015-03-24 03:05:57]

>
https://codereview.chromium.org/1029043002/diff/1/ui/accessibility/platform/a...
> ui/accessibility/platform/ax_platform_node_auralinux.cc:91: 
> nit: get rid of this blank line at the beginning of the function

Done

>
https://codereview.chromium.org/1029043002/diff/1/ui/accessibility/platform/a...
> ui/accessibility/platform/ax_platform_node_auralinux.cc:103: bool
> atk_object_found = (child == atk_object)?true:false;
> nit: git rid of "?true:false", it's not needed

Done

>
https://codereview.chromium.org/1029043002/diff/1/ui/accessibility/platform/a...
> ui/accessibility/platform/ax_platform_node_auralinux.cc:104:
> g_object_unref(child);
> in a separate changelist, could you look into the possibility of writing a
> wrapper class like scoped_gobject? (similar to ScopedComPtr or scoped_ptr).

Yes. I ll look into the possiblity of that.

>
https://codereview.chromium.org/1029043002/diff/1/ui/accessibility/platform/a...
> ui/accessibility/platform/ax_platform_node_auralinux.cc:359: return;
> nit: no "return", just leave it blank.

Done

>
https://codereview.chromium.org/1029043002/diff/1/ui/accessibility/platform/a...
> ui/accessibility/platform/ax_platform_node_auralinux.h:27: void
> GetAtkRelation(AtkRelationSet* atk_relation_set);
> I'd call this GetAtkRelations

Done.

[commit-bot: I haz the power, 2015-03-24 03:42:19]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-24 03:43:08]

Patchset 3 (id:??) landed as
https://crrev.com/7d5426fdb05ade9631fa3d9d0fe6135b272eb147
Cr-Commit-Position: refs/heads/master@{#321929}