Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1028993003: X87: Simplify pending message script handling. (Closed)

Created:
5 years, 9 months ago by chunyang.dai
Modified:
5 years, 9 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Simplify pending message script handling. port f71e26268338d2840133264329bf35a63011bb5a (r27127) original commit message: Simplify pending message script handling. This removes the separate tracking of the pending message script, because that script is already stored in the message object and duplicating it in the ThreadLocalTop makes it more brittle. BUG= R=weiliang.lin@intel.com Committed: https://chromium.googlesource.com/v8/v8/+/01f1348614ab3f3ac26674d3cc685cb8ed626052

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M src/x87/full-codegen-x87.cc View 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL.
5 years, 9 months ago (2015-03-23 09:22:08 UTC) #2
Weiliang
lgtm
5 years, 9 months ago (2015-03-23 09:24:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1028993003/1
5 years, 9 months ago (2015-03-23 09:24:23 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/01f1348614ab3f3ac26674d3cc685cb8ed626052 Cr-Commit-Position: refs/heads/master@{#27358}
5 years, 9 months ago (2015-03-23 09:28:00 UTC) #6
chunyang.dai
5 years, 9 months ago (2015-03-23 09:28:03 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
01f1348614ab3f3ac26674d3cc685cb8ed626052 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698