Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: src/x87/full-codegen-x87.cc

Issue 1028993003: X87: Simplify pending message script handling. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X87 7 #if V8_TARGET_ARCH_X87
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 5225 matching lines...) Expand 10 before | Expand all | Expand 10 after
5236 ExternalReference pending_message_obj = 5236 ExternalReference pending_message_obj =
5237 ExternalReference::address_of_pending_message_obj(isolate()); 5237 ExternalReference::address_of_pending_message_obj(isolate());
5238 __ mov(edx, Operand::StaticVariable(pending_message_obj)); 5238 __ mov(edx, Operand::StaticVariable(pending_message_obj));
5239 __ push(edx); 5239 __ push(edx);
5240 5240
5241 ExternalReference has_pending_message = 5241 ExternalReference has_pending_message =
5242 ExternalReference::address_of_has_pending_message(isolate()); 5242 ExternalReference::address_of_has_pending_message(isolate());
5243 __ mov(edx, Operand::StaticVariable(has_pending_message)); 5243 __ mov(edx, Operand::StaticVariable(has_pending_message));
5244 __ SmiTag(edx); 5244 __ SmiTag(edx);
5245 __ push(edx); 5245 __ push(edx);
5246
5247 ExternalReference pending_message_script =
5248 ExternalReference::address_of_pending_message_script(isolate());
5249 __ mov(edx, Operand::StaticVariable(pending_message_script));
5250 __ push(edx);
5251 } 5246 }
5252 5247
5253 5248
5254 void FullCodeGenerator::ExitFinallyBlock() { 5249 void FullCodeGenerator::ExitFinallyBlock() {
5255 DCHECK(!result_register().is(edx)); 5250 DCHECK(!result_register().is(edx));
5256 // Restore pending message from stack. 5251 // Restore pending message from stack.
5257 __ pop(edx); 5252 __ pop(edx);
5258 ExternalReference pending_message_script =
5259 ExternalReference::address_of_pending_message_script(isolate());
5260 __ mov(Operand::StaticVariable(pending_message_script), edx);
5261
5262 __ pop(edx);
5263 __ SmiUntag(edx); 5253 __ SmiUntag(edx);
5264 ExternalReference has_pending_message = 5254 ExternalReference has_pending_message =
5265 ExternalReference::address_of_has_pending_message(isolate()); 5255 ExternalReference::address_of_has_pending_message(isolate());
5266 __ mov(Operand::StaticVariable(has_pending_message), edx); 5256 __ mov(Operand::StaticVariable(has_pending_message), edx);
5267 5257
5268 __ pop(edx); 5258 __ pop(edx);
5269 ExternalReference pending_message_obj = 5259 ExternalReference pending_message_obj =
5270 ExternalReference::address_of_pending_message_obj(isolate()); 5260 ExternalReference::address_of_pending_message_obj(isolate());
5271 __ mov(Operand::StaticVariable(pending_message_obj), edx); 5261 __ mov(Operand::StaticVariable(pending_message_obj), edx);
5272 5262
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
5384 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(), 5374 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(),
5385 Assembler::target_address_at(call_target_address, 5375 Assembler::target_address_at(call_target_address,
5386 unoptimized_code)); 5376 unoptimized_code));
5387 return OSR_AFTER_STACK_CHECK; 5377 return OSR_AFTER_STACK_CHECK;
5388 } 5378 }
5389 5379
5390 5380
5391 } } // namespace v8::internal 5381 } } // namespace v8::internal
5392 5382
5393 #endif // V8_TARGET_ARCH_X87 5383 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698