Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 1028953002: Check null java object when request vsync (Closed)

Created:
5 years, 9 months ago by boliu
Modified:
5 years, 9 months ago
Reviewers:
Ted C
CC:
chromium-reviews, sunnyps
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check null java object when request vsync BUG= Committed: https://crrev.com/2e16485f8fe45f6480364fcbec89630f650c42b5 Cr-Commit-Position: refs/heads/master@{#321870}

Patch Set 1 #

Total comments: 1

Patch Set 2 : semicolon #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M ui/android/window_android.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
boliu
ptal This small fix is to unblock https://codereview.chromium.org/817603002/ Although we probably should do something about ...
5 years, 9 months ago (2015-03-23 17:16:33 UTC) #2
Ted C
lgtm
5 years, 9 months ago (2015-03-23 17:31:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1028953002/1
5 years, 9 months ago (2015-03-23 17:33:17 UTC) #5
boliu
wow, this broke loads of tests, wonderful..
5 years, 9 months ago (2015-03-23 18:38:02 UTC) #7
boliu
On 2015/03/23 18:38:02, boliu wrote: > wow, this broke loads of tests, wonderful.. I missed ...
5 years, 9 months ago (2015-03-23 21:15:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1028953002/20001
5 years, 9 months ago (2015-03-23 21:17:08 UTC) #11
Ted C
https://codereview.chromium.org/1028953002/diff/1/ui/android/window_android.cc File ui/android/window_android.cc (right): https://codereview.chromium.org/1028953002/diff/1/ui/android/window_android.cc#newcode77 ui/android/window_android.cc:77: return wow...that is awesome...completely missed it!
5 years, 9 months ago (2015-03-23 21:18:13 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-23 22:21:11 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 22:22:31 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2e16485f8fe45f6480364fcbec89630f650c42b5
Cr-Commit-Position: refs/heads/master@{#321870}

Powered by Google App Engine
This is Rietveld 408576698