ui/android/window_android.cc - Issue 1028953002: Check null java object when request vsync

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/android/window_android.cc

Issue 1028953002: Check null java object when request vsync (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: semicolon Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/android/window_android.cc

diff --git a/ui/android/window_android.cc b/ui/android/window_android.cc

index 172a7ae2f37f51600e7dcb5c32f5c875cbdca96b..cb163ff817da316f5f01edc92c2c256068c07a88 100644

--- a/ui/android/window_android.cc

+++ b/ui/android/window_android.cc

@@ -72,7 +72,10 @@ void WindowAndroid::DetachCompositor() {

void WindowAndroid::RequestVSyncUpdate() {

JNIEnv* env = AttachCurrentThread();

- Java_WindowAndroid_requestVSyncUpdate(env, GetJavaObject().obj());

+ ScopedJavaLocalRef<jobject> obj = GetJavaObject();

+ if (obj.is_null())

+ return;

+ Java_WindowAndroid_requestVSyncUpdate(env, obj.obj());

}

void WindowAndroid::SetNeedsAnimate() {

« no previous file with comments | « no previous file | no next file » | no next file with comments »