Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1028893002: PagePopups should have the grab behavior same as <select> popup. (Closed)

Created:
5 years, 9 months ago by tkent
Modified:
5 years, 9 months ago
Reviewers:
ananta, sadrul
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PagePopups should have the grab behavior same as <select> popup. PagePopups used for <input type=date>, <datalist>, etc. should have same input grab behavior as <select> popup. Also, <select> popup is going to be switched to blink::WebPopupTypePage. BUG=346582 Committed: https://crrev.com/627e7b0e708021d0657cc8b6411f274a5fb0d855 Cr-Commit-Position: refs/heads/master@{#321818}

Patch Set 1 #

Total comments: 2

Patch Set 2 : style nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
tkent
ananta@, sadrul@, would you review this please?
5 years, 9 months ago (2015-03-23 00:24:23 UTC) #2
sadrul
lgtm https://codereview.chromium.org/1028893002/diff/1/content/browser/renderer_host/render_widget_host_view_aura.cc File content/browser/renderer_host/render_widget_host_view_aura.cc (right): https://codereview.chromium.org/1028893002/diff/1/content/browser/renderer_host/render_widget_host_view_aura.cc#newcode2391 content/browser/renderer_host/render_widget_host_view_aura.cc:2391: || popup_type_ == blink::WebPopupTypePage; I think the style-guide ...
5 years, 9 months ago (2015-03-23 07:05:39 UTC) #3
tkent
https://codereview.chromium.org/1028893002/diff/1/content/browser/renderer_host/render_widget_host_view_aura.cc File content/browser/renderer_host/render_widget_host_view_aura.cc (right): https://codereview.chromium.org/1028893002/diff/1/content/browser/renderer_host/render_widget_host_view_aura.cc#newcode2391 content/browser/renderer_host/render_widget_host_view_aura.cc:2391: || popup_type_ == blink::WebPopupTypePage; On 2015/03/23 07:05:38, sadrul wrote: ...
5 years, 9 months ago (2015-03-23 07:08:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1028893002/20001
5 years, 9 months ago (2015-03-23 18:11:10 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-23 18:45:54 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 18:46:36 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/627e7b0e708021d0657cc8b6411f274a5fb0d855
Cr-Commit-Position: refs/heads/master@{#321818}

Powered by Google App Engine
This is Rietveld 408576698