content/browser/renderer_host/render_widget_host_view_aura.cc - Issue 1028893002: PagePopups should have the grab behavior same as <select> popup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 1028893002: PagePopups should have the grab behavior same as <select> popup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: style nit Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/renderer_host/render_widget_host_view_aura.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc

index 2b1704f20e6cf04234a310e52fd88995f7652ef5..55a92d0fd397ea4c010027b568c1e2ae9a2eed59 100644

--- a/content/browser/renderer_host/render_widget_host_view_aura.cc

+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc

@@ -2387,7 +2387,8 @@ void RenderWidgetHostViewAura::Shutdown() {

}

bool RenderWidgetHostViewAura::NeedsInputGrab() {

- return popup_type_ == blink::WebPopupTypeSelect;

+ return popup_type_ == blink::WebPopupTypeSelect ||

+ popup_type_ == blink::WebPopupTypePage;

}

bool RenderWidgetHostViewAura::NeedsMouseCapture() {

« no previous file with comments | « no previous file | no next file » | no next file with comments »