Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1028873002: Use uint32_t to hold return values from ERR_get_error() and ERR_peek_error(). (Closed)

Created:
5 years, 9 months ago by eroman
Modified:
5 years, 9 months ago
Reviewers:
davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use uint32_t to hold return values from ERR_get_error() and ERR_peek_error(). BUG=None Committed: https://crrev.com/46f7dd8bd81d2f1fe3053ae902b6b83123691b14 Cr-Commit-Position: refs/heads/master@{#321919}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M crypto/openssl_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/test_root_certs_openssl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/crypto/aead_base_decrypter_openssl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/flip_server/spdy_ssl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
eroman
just a code hygiene thing, i dont think any of these were currently bugs
5 years, 9 months ago (2015-03-21 23:35:29 UTC) #2
davidben
lgtm
5 years, 9 months ago (2015-03-23 23:38:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1028873002/1
5 years, 9 months ago (2015-03-23 23:48:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 01:40:16 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 01:41:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46f7dd8bd81d2f1fe3053ae902b6b83123691b14
Cr-Commit-Position: refs/heads/master@{#321919}

Powered by Google App Engine
This is Rietveld 408576698