net/cert/test_root_certs_openssl.cc - Issue 1028873002: Use uint32_t to hold return values from ERR_get_error() and ERR_peek_error().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/test_root_certs_openssl.cc

Issue 1028873002: Use uint32_t to hold return values from ERR_get_error() and ERR_peek_error(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/cert/test_root_certs_openssl.cc

diff --git a/net/cert/test_root_certs_openssl.cc b/net/cert/test_root_certs_openssl.cc

index 1b194bc646f7d69e3d7bb9d52ff0ff055a554805..76906d86f00d66a33bfecdd30056da7a0869c273 100644

--- a/net/cert/test_root_certs_openssl.cc

+++ b/net/cert/test_root_certs_openssl.cc

@@ -17,7 +17,7 @@ namespace net {

bool TestRootCerts::Add(X509Certificate* certificate) {

if (!X509_STORE_add_cert(X509Certificate::cert_store(),

certificate->os_cert_handle())) {

- unsigned long error_code = ERR_peek_error();

+ uint32_t error_code = ERR_peek_error();

if (ERR_GET_LIB(error_code) != ERR_LIB_X509 ||

ERR_GET_REASON(error_code) != X509_R_CERT_ALREADY_IN_HASH_TABLE) {

crypto::ClearOpenSSLERRStack(FROM_HERE);

« no previous file with comments | « crypto/openssl_util.cc ('k') | net/quic/crypto/aead_base_decrypter_openssl.cc » ('j') | no next file with comments »