Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1028653002: Oilpan: fix webkit unit tests following r192243 (reland). (Closed)

Created:
5 years, 9 months ago by sof
Modified:
5 years, 9 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: fix webkit unit tests following r192243 (reland). R=haraken BUG=467890 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192276

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M Source/core/dom/ScriptRunnerTest.cpp View 1 chunk +5 lines, -2 lines 2 comments Download

Messages

Total messages: 8 (2 generated)
sof
Please take a look. MSVC considered the loop access (scriptLoaders[i].get()) for scriptLoaders OwnPtrWillBeRawPtr<...> scriptLoaders[loaderCount]; as ...
5 years, 9 months ago (2015-03-20 14:05:53 UTC) #1
haraken
https://codereview.chromium.org/1028653002/diff/1/Source/core/dom/ScriptRunnerTest.cpp File Source/core/dom/ScriptRunnerTest.cpp (right): https://codereview.chromium.org/1028653002/diff/1/Source/core/dom/ScriptRunnerTest.cpp#newcode387 Source/core/dom/ScriptRunnerTest.cpp:387: scriptLoaders[i] = nullptr; What is this nullptr assignment for?
5 years, 9 months ago (2015-03-20 14:07:42 UTC) #3
sof
https://codereview.chromium.org/1028653002/diff/1/Source/core/dom/ScriptRunnerTest.cpp File Source/core/dom/ScriptRunnerTest.cpp (right): https://codereview.chromium.org/1028653002/diff/1/Source/core/dom/ScriptRunnerTest.cpp#newcode387 Source/core/dom/ScriptRunnerTest.cpp:387: scriptLoaders[i] = nullptr; On 2015/03/20 14:07:42, haraken wrote: > ...
5 years, 9 months ago (2015-03-20 14:15:16 UTC) #4
haraken
LGTM
5 years, 9 months ago (2015-03-20 14:32:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1028653002/1
5 years, 9 months ago (2015-03-20 14:35:58 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 19:13:05 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192276

Powered by Google App Engine
This is Rietveld 408576698