 Chromium Code Reviews
 Chromium Code Reviews Issue 1028653002:
  Oilpan: fix webkit unit tests following r192243 (reland).  (Closed) 
  Base URL: svn://svn.chromium.org/blink/trunk
    
  
    Issue 1028653002:
  Oilpan: fix webkit unit tests following r192243 (reland).  (Closed) 
  Base URL: svn://svn.chromium.org/blink/trunk| Index: Source/core/dom/ScriptRunnerTest.cpp | 
| diff --git a/Source/core/dom/ScriptRunnerTest.cpp b/Source/core/dom/ScriptRunnerTest.cpp | 
| index 14a3c3a00be0e193ee6496737005057031e33133..00669b8421cf6abce026212f64f7f55095afea3f 100644 | 
| --- a/Source/core/dom/ScriptRunnerTest.cpp | 
| +++ b/Source/core/dom/ScriptRunnerTest.cpp | 
| @@ -382,9 +382,12 @@ TEST_F(ScriptRunnerTest, ShouldYield_AsyncScripts) | 
| TEST_F(ScriptRunnerTest, QueueReentrantScript_ManyAsyncScripts) | 
| { | 
| - OwnPtr<MockScriptLoader> scriptLoaders[20]; | 
| + OwnPtrWillBeRawPtr<MockScriptLoader> scriptLoaders[20]; | 
| + for (int i = 0; i < 20; i++) | 
| + scriptLoaders[i] = nullptr; | 
| 
haraken
2015/03/20 14:07:42
What is this nullptr assignment for?
 
sof
2015/03/20 14:15:16
Being tidy wrt RawPtr<> zero initialization, nothi
 | 
| + | 
| for (int i = 0; i < 20; i++) { | 
| - scriptLoaders[i] = adoptPtr(new MockScriptLoader(m_element.get())); | 
| + scriptLoaders[i] = adoptPtrWillBeNoop(new MockScriptLoader(m_element.get())); | 
| EXPECT_CALL(*scriptLoaders[i], isReady()).WillRepeatedly(Return(true)); | 
| m_scriptRunner->queueScriptForExecution(scriptLoaders[i].get(), ScriptRunner::ASYNC_EXECUTION); |