Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1028603003: Fast user switcher: Distinguish supervised users from child accounts (Closed)

Created:
5 years, 9 months ago by Marc Treib
Modified:
5 years, 9 months ago
CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fast user switcher: Distinguish supervised users from child accounts Followup to https://crrev.com/1018003002 BUG=463463 Committed: https://crrev.com/791bba38f9d27614827bfbdf1b474f0b30a3f8b0 Cr-Commit-Position: refs/heads/master@{#322041}

Patch Set 1 #

Patch Set 2 : Mac #

Total comments: 2

Patch Set 3 : DCHECK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -12 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/profiles/profile_list_chromeos.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/profiles/avatar_menu.h View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_list_desktop.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_menu_controller.mm View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
Marc Treib
noms for c/b/profiles, msw for c/b/ui. PTAL! Before/after screenshots (from the bug): https://chromium.googlecode.com/issues/attachment?aid=4634630015000&name=fast_user_switcher_2.png&token=ABZ6GAfwsWlZLeFwhADtm2zZYNR64JQErA%3A1427106817263&inline=1 https://chromium.googlecode.com/issues/attachment?aid=4634630018000&name=fast_user_switcher_3.png&token=ABZ6GAeogZHEHeGS_6lM782dBaJ-bbk3QA%3A1427106817268&inline=1
5 years, 9 months ago (2015-03-23 10:34:20 UTC) #2
msw
https://codereview.chromium.org/1028603003/diff/20001/chrome/browser/chromeos/profiles/profile_list_chromeos.cc File chrome/browser/chromeos/profiles/profile_list_chromeos.cc (right): https://codereview.chromium.org/1028603003/diff/20001/chrome/browser/chromeos/profiles/profile_list_chromeos.cc#newcode66 chrome/browser/chromeos/profiles/profile_list_chromeos.cc:66: item->legacy_supervised = false; Should this be using ProfileIsLegacySupervisedAtIndex or ...
5 years, 9 months ago (2015-03-23 19:28:33 UTC) #3
noms (inactive)
lgtm
5 years, 9 months ago (2015-03-24 14:07:51 UTC) #4
Marc Treib
https://codereview.chromium.org/1028603003/diff/20001/chrome/browser/chromeos/profiles/profile_list_chromeos.cc File chrome/browser/chromeos/profiles/profile_list_chromeos.cc (right): https://codereview.chromium.org/1028603003/diff/20001/chrome/browser/chromeos/profiles/profile_list_chromeos.cc#newcode66 chrome/browser/chromeos/profiles/profile_list_chromeos.cc:66: item->legacy_supervised = false; On 2015/03/23 19:28:33, msw wrote: > ...
5 years, 9 months ago (2015-03-24 15:03:14 UTC) #5
Marc Treib
+dpolukhin: Can I get an OWNERS review for profile_list_chromeos.cc, please?
5 years, 9 months ago (2015-03-24 15:03:57 UTC) #7
Dmitry Polukhin
LGTM profile_list_chromeos.cc
5 years, 9 months ago (2015-03-24 15:13:10 UTC) #8
msw
lgtm
5 years, 9 months ago (2015-03-24 17:25:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1028603003/40001
5 years, 9 months ago (2015-03-24 17:33:51 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-24 19:07:30 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 19:08:19 UTC) #13
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/791bba38f9d27614827bfbdf1b474f0b30a3f8b0
Cr-Commit-Position: refs/heads/master@{#322041}

Powered by Google App Engine
This is Rietveld 408576698