Fast user switcher: Distinguish supervised users from child accounts

chrome/browser/chromeos/profiles/profile_list_chromeos.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/profiles/profile_list_chromeos.h"
 
 #include <algorithm>
 
 #include "ash/shell.h"
 #include "base/command_line.h"
@@ skipping 45 matching lines @@
     gfx::Image icon = gfx::Image((*it)->GetImage());
     if (!switches::IsNewProfileManagement() && !icon.IsEmpty()) {
       // old avatar menu uses resized-small images
       icon = profiles::GetAvatarIconForMenu(icon, true);
     }
 
     AvatarMenu::Item* item = new AvatarMenu::Item(i, i, icon);
     item->name = (*it)->GetDisplayName();
     item->sync_state = profile_info_->GetUserNameOfProfileAtIndex(i);
     item->profile_path = profile_info_->GetPathOfProfileAtIndex(i);
-    item->supervised = false;
+    item->legacy_supervised = false;

[msw, 2015/03/23 19:28:33]

Should this be using ProfileIsLegacySupervisedAtIndex or
ProfileIsSupervisedAtIndex?

[Marc Treib, 2015/03/24 15:03:14]

On CrOS, we should never get a legacy supervised user in the multiprofile menu.
I've added a DCHECK to make sure (and hopefully help the next one to read this
code).

+    item->child_account = profile_info_->ProfileIsChildAtIndex(i);
     item->signed_in = true;
     item->active = profile_info_->GetPathOfProfileAtIndex(i) ==
         active_profile_path_;
     item->signin_required = profile_info_->ProfileIsSigninRequiredAtIndex(i);
     items_.push_back(item);
   }
 
   SortMenu();
 
   // After sorting, assign items their actual indices.
@@ skipping 23 matching lines @@
 void ProfileListChromeOS::ClearMenu() {
   STLDeleteElements(&items_);
 }
 
 void ProfileListChromeOS::SortMenu() {
   // Sort list of items by name.
   std::sort(items_.begin(), items_.end(), &AvatarMenu::CompareItems);
 }
 
 }  // namespace chromeos