Issue 1028563002: [turbofan] Improve typing for string::length property.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1028563002: [turbofan] Improve typing for string::length property. (Closed)

Created:
5 years, 9 months ago by Benedikt Meurer

Modified:
5 years, 9 months ago

Reviewers:
dcarney

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[turbofan] Improve typing for string::length property. R=dcarney@chromium.org Committed: https://crrev.com/b99f17a26f94ab9dc21e7661671f0fc71c1fdc3b Cr-Commit-Position: refs/heads/master@{#27330}

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	src/compiler/access-builder.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	src/compiler/typer.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 7 (1 generated)

dcarney

lgtm would be nice if we could share that info somehow. i'm sure this is ...

5 years, 9 months ago (2015-03-20 08:28:47 UTC) #3

Benedikt Meurer

On 2015/03/20 08:28:47, dcarney wrote: > lgtm > > would be nice if we could ...

5 years, 9 months ago (2015-03-20 08:35:30 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1028563002/1

5 years, 9 months ago (2015-03-20 08:35:57 UTC) #6

commit-bot: I haz the power

5 years, 9 months ago (2015-03-20 08:41:05 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/b99f17a26f94ab9dc21e7661671f0fc71c1fdc3b
Cr-Commit-Position: refs/heads/master@{#27330}