Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Side by Side Diff: src/compiler/access-builder.cc

Issue 1028563002: [turbofan] Improve typing for string::length property. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/compiler/typer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/access-builder.h" 5 #include "src/compiler/access-builder.h"
6 #include "src/types-inl.h" 6 #include "src/types-inl.h"
7 7
8 namespace v8 { 8 namespace v8 {
9 namespace internal { 9 namespace internal {
10 namespace compiler { 10 namespace compiler {
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 // static 54 // static
55 FieldAccess AccessBuilder::ForMapInstanceType() { 55 FieldAccess AccessBuilder::ForMapInstanceType() {
56 return {kTaggedBase, Map::kInstanceTypeOffset, Handle<Name>(), 56 return {kTaggedBase, Map::kInstanceTypeOffset, Handle<Name>(),
57 Type::UntaggedUnsigned8(), kMachUint8}; 57 Type::UntaggedUnsigned8(), kMachUint8};
58 } 58 }
59 59
60 60
61 // static 61 // static
62 FieldAccess AccessBuilder::ForStringLength() { 62 FieldAccess AccessBuilder::ForStringLength() {
63 return {kTaggedBase, String::kLengthOffset, Handle<Name>(), 63 return {kTaggedBase, String::kLengthOffset, Handle<Name>(),
64 Type::SignedSmall(), kMachAnyTagged}; 64 Type::Intersect(Type::UnsignedSmall(), Type::TaggedSigned()),
65 kMachAnyTagged};
65 } 66 }
66 67
67 68
68 // static 69 // static
69 FieldAccess AccessBuilder::ForValue() { 70 FieldAccess AccessBuilder::ForValue() {
70 return {kTaggedBase, JSValue::kValueOffset, Handle<Name>(), Type::Any(), 71 return {kTaggedBase, JSValue::kValueOffset, Handle<Name>(), Type::Any(),
71 kMachAnyTagged}; 72 kMachAnyTagged};
72 } 73 }
73 74
74 75
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 case kExternalFloat64Array: 112 case kExternalFloat64Array:
112 return {taggedness, header_size, Type::Number(), kMachFloat64}; 113 return {taggedness, header_size, Type::Number(), kMachFloat64};
113 } 114 }
114 UNREACHABLE(); 115 UNREACHABLE();
115 return {kUntaggedBase, 0, Type::None(), kMachNone}; 116 return {kUntaggedBase, 0, Type::None(), kMachNone};
116 } 117 }
117 118
118 } // namespace compiler 119 } // namespace compiler
119 } // namespace internal 120 } // namespace internal
120 } // namespace v8 121 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/compiler/typer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698