Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: chrome/browser/browser_resources.grd

Issue 1028503006: Add Media Router WebUI icons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/media_router/elements/icon/chromecast-icon-16.png » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_resources.grd
diff --git a/chrome/browser/browser_resources.grd b/chrome/browser/browser_resources.grd
index 5874f4af94c61ee653da535878b15a2b83dff9b0..e5055dc441686dc4d93682c845e74fc0a5a27f08 100644
--- a/chrome/browser/browser_resources.grd
+++ b/chrome/browser/browser_resources.grd
@@ -447,6 +447,28 @@
<include name="IDR_WHISPERNET_PROXY_MANIFEST" file="resources\whispernet_proxy\manifest.json" type="BINDATA" />
<include name="IDR_MD_SETTINGS_UI_HTML" file="resources\md_settings\md_settings.html" type="BINDATA" />
<include name="IDR_MD_SETTINGS_UI_CSS" file="resources\md_settings\md_settings.css" type="BINDATA" />
+ <if expr="enable_media_router">
+ <include name="IDR_MEDIA_ROUTER_CHROMECAST_16_ICON" file="resources\media_router\elements\icon\chromecast-icon-16.png" type="BINDATA" />
+ <include name="IDR_MEDIA_ROUTER_CHROMECAST_32_ICON" file="resources\media_router\elements\icon\chromecast-icon-32.png" type="BINDATA" />
mark a. foltz 2015/03/23 17:49:57 How does the 32.png look on a Retina display?
apacible 2015/03/23 18:22:48 It's not as sharp as it could be. This goes for mo
+ <include name="IDR_CLOSE_GRAY_ICON" file="resources\media_router\elements\icon\close-gray.png" type="BINDATA" />
+ <include name="IDR_CLOSE_GRAY_2X_ICON" file="resources\media_router\elements\icon\close-gray2x.png" type="BINDATA" />
mark a. foltz 2015/03/23 17:49:57 I would like to be consistent with file naming, us
apacible 2015/03/23 18:22:48 Done.
+ <include name="IDR_DOWN_ARROW_ICON" file="resources\media_router\elements\icon\down-arrow.png" type="BINDATA" />
+ <include name="IDR_DOWN_ARROW_HOVER_ICON" file="resources\media_router\elements\icon\down-arrow-hover.png" type="BINDATA" />
+ <include name="IDR_DOWN_ARROW_SHOWING_ICON" file="resources\media_router\elements\icon\down-arrow-showing.png" type="BINDATA" />
mark a. foltz 2015/03/23 17:49:57 This PNG looked corrupted in Reitveld? Or maybe j
apacible 2015/03/23 18:22:48 It looks a lot better on a file explorer and image
+ <include name="IDR_MEDIA_ROUTER_GENERIC_DEVICE_16_ICON" file="resources\media_router\elements\icon\generic-device-16.png" type="BINDATA" />
+ <include name="IDR_MEDIA_ROUTER_GENERIC_DEVICE_32_ICON" file="resources\media_router\elements\icon\generic-device-32.png" type="BINDATA" />
+ <include name="IDR_MEDIA_ROUTER_HANGOUTS_16_ICON" file="resources\media_router\elements\icon\hangouts-icon-16.png" type="BINDATA" />
+ <include name="IDR_MEDIA_ROUTER_HANGOUTS_32_ICON" file="resources\media_router\elements\icon\hangouts-icon-32.png" type="BINDATA" />
+ <include name="IDR_MUTE_ICON" file="resources\media_router\elements\icon\mute.png" type="BINDATA" />
mark a. foltz 2015/03/23 17:49:57 Per offline convo, since we are not planning on su
apacible 2015/03/23 18:22:48 Removed mute, pause, play, unmute.
+ <include name="IDR_MUTE_2X_ICON" file="resources\media_router\elements\icon\mute2x.png" type="BINDATA" />
+ <include name="IDR_PAUSE_ICON" file="resources\media_router\elements\icon\pause.png" type="BINDATA" />
+ <include name="IDR_PAUSE_2X_ICON" file="resources\media_router\elements\icon\pause2x.png" type="BINDATA" />
+ <include name="IDR_PLAY_ICON" file="resources\media_router\elements\icon\play.png" type="BINDATA" />
+ <include name="IDR_PLAY_2X_ICON" file="resources\media_router\elements\icon\play2x.png" type="BINDATA" />
+ <include name="IDR_SAD_FACE_ICON" file="resources\media_router\elements\icon\sad-face.png" type="BINDATA" />
mark a. foltz 2015/03/23 17:49:57 Does this have a 2X version?
apacible 2015/03/23 18:22:48 Not at the moment. I'll talk to Jonny about that.
+ <include name="IDR_UNMUTE_ICON" file="resources\media_router\elements\icon\unmute.png" type="BINDATA" />
+ <include name="IDR_UNMUTE_2X_ICON" file="resources\media_router\elements\icon\unmute2x.png" type="BINDATA" />
+ </if>
</includes>
</release>
</grit>
« no previous file with comments | « no previous file | chrome/browser/resources/media_router/elements/icon/chromecast-icon-16.png » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698