Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Side by Side Diff: chrome/browser/browser_resources.grd

Issue 1028503006: Add Media Router WebUI icons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/media_router/elements/icon/chromecast-icon-16.png » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="UTF-8"?> 1 <?xml version="1.0" encoding="UTF-8"?>
2 <grit latest_public_release="0" current_release="1"> 2 <grit latest_public_release="0" current_release="1">
3 <outputs> 3 <outputs>
4 <output filename="grit/browser_resources.h" type="rc_header"> 4 <output filename="grit/browser_resources.h" type="rc_header">
5 <emit emit_type='prepend'></emit> 5 <emit emit_type='prepend'></emit>
6 </output> 6 </output>
7 <output filename="browser_resources.pak" type="data_package" /> 7 <output filename="browser_resources.pak" type="data_package" />
8 </outputs> 8 </outputs>
9 <release seq="1"> 9 <release seq="1">
10 <structures> 10 <structures>
(...skipping 429 matching lines...) Expand 10 before | Expand all | Expand 10 after
440 <include name="IDR_ZHUYIN_MANIFEST" file="resources\chromeos\input_met hod\zhuyin_manifest.json" type="BINDATA" /> 440 <include name="IDR_ZHUYIN_MANIFEST" file="resources\chromeos\input_met hod\zhuyin_manifest.json" type="BINDATA" />
441 <include name="IDR_CANGJIE_MANIFEST" file="resources\chromeos\input_me thod\cangjie_manifest.json" type="BINDATA" /> 441 <include name="IDR_CANGJIE_MANIFEST" file="resources\chromeos\input_me thod\cangjie_manifest.json" type="BINDATA" />
442 <include name="IDR_MOZC_MANIFEST" file="resources\chromeos\input_metho d\mozc_manifest.json" type="BINDATA" /> 442 <include name="IDR_MOZC_MANIFEST" file="resources\chromeos\input_metho d\mozc_manifest.json" type="BINDATA" />
443 </if> 443 </if>
444 <include name="IDR_HANGUL_MANIFEST" file="resources\chromeos\input_metho d\hangul_manifest.json" type="BINDATA" /> 444 <include name="IDR_HANGUL_MANIFEST" file="resources\chromeos\input_metho d\hangul_manifest.json" type="BINDATA" />
445 <include name="IDR_BRAILLE_MANIFEST" file="resources\chromeos\braille_im e\manifest.json" type="BINDATA" /> 445 <include name="IDR_BRAILLE_MANIFEST" file="resources\chromeos\braille_im e\manifest.json" type="BINDATA" />
446 </if> 446 </if>
447 <include name="IDR_WHISPERNET_PROXY_MANIFEST" file="resources\whispernet_p roxy\manifest.json" type="BINDATA" /> 447 <include name="IDR_WHISPERNET_PROXY_MANIFEST" file="resources\whispernet_p roxy\manifest.json" type="BINDATA" />
448 <include name="IDR_MD_SETTINGS_UI_HTML" file="resources\md_settings\md_set tings.html" type="BINDATA" /> 448 <include name="IDR_MD_SETTINGS_UI_HTML" file="resources\md_settings\md_set tings.html" type="BINDATA" />
449 <include name="IDR_MD_SETTINGS_UI_CSS" file="resources\md_settings\md_sett ings.css" type="BINDATA" /> 449 <include name="IDR_MD_SETTINGS_UI_CSS" file="resources\md_settings\md_sett ings.css" type="BINDATA" />
450 <if expr="enable_media_router">
451 <include name="IDR_MEDIA_ROUTER_CHROMECAST_16_ICON" file="resources\medi a_router\elements\icon\chromecast-icon-16.png" type="BINDATA" />
452 <include name="IDR_MEDIA_ROUTER_CHROMECAST_32_ICON" file="resources\medi a_router\elements\icon\chromecast-icon-32.png" type="BINDATA" />
mark a. foltz 2015/03/23 17:49:57 How does the 32.png look on a Retina display?
apacible 2015/03/23 18:22:48 It's not as sharp as it could be. This goes for mo
453 <include name="IDR_CLOSE_GRAY_ICON" file="resources\media_router\element s\icon\close-gray.png" type="BINDATA" />
454 <include name="IDR_CLOSE_GRAY_2X_ICON" file="resources\media_router\elem ents\icon\close-gray2x.png" type="BINDATA" />
mark a. foltz 2015/03/23 17:49:57 I would like to be consistent with file naming, us
apacible 2015/03/23 18:22:48 Done.
455 <include name="IDR_DOWN_ARROW_ICON" file="resources\media_router\element s\icon\down-arrow.png" type="BINDATA" />
456 <include name="IDR_DOWN_ARROW_HOVER_ICON" file="resources\media_router\e lements\icon\down-arrow-hover.png" type="BINDATA" />
457 <include name="IDR_DOWN_ARROW_SHOWING_ICON" file="resources\media_router \elements\icon\down-arrow-showing.png" type="BINDATA" />
mark a. foltz 2015/03/23 17:49:57 This PNG looked corrupted in Reitveld? Or maybe j
apacible 2015/03/23 18:22:48 It looks a lot better on a file explorer and image
458 <include name="IDR_MEDIA_ROUTER_GENERIC_DEVICE_16_ICON" file="resources\ media_router\elements\icon\generic-device-16.png" type="BINDATA" />
459 <include name="IDR_MEDIA_ROUTER_GENERIC_DEVICE_32_ICON" file="resources\ media_router\elements\icon\generic-device-32.png" type="BINDATA" />
460 <include name="IDR_MEDIA_ROUTER_HANGOUTS_16_ICON" file="resources\media_ router\elements\icon\hangouts-icon-16.png" type="BINDATA" />
461 <include name="IDR_MEDIA_ROUTER_HANGOUTS_32_ICON" file="resources\media_ router\elements\icon\hangouts-icon-32.png" type="BINDATA" />
462 <include name="IDR_MUTE_ICON" file="resources\media_router\elements\icon \mute.png" type="BINDATA" />
mark a. foltz 2015/03/23 17:49:57 Per offline convo, since we are not planning on su
apacible 2015/03/23 18:22:48 Removed mute, pause, play, unmute.
463 <include name="IDR_MUTE_2X_ICON" file="resources\media_router\elements\i con\mute2x.png" type="BINDATA" />
464 <include name="IDR_PAUSE_ICON" file="resources\media_router\elements\ico n\pause.png" type="BINDATA" />
465 <include name="IDR_PAUSE_2X_ICON" file="resources\media_router\elements\ icon\pause2x.png" type="BINDATA" />
466 <include name="IDR_PLAY_ICON" file="resources\media_router\elements\icon \play.png" type="BINDATA" />
467 <include name="IDR_PLAY_2X_ICON" file="resources\media_router\elements\i con\play2x.png" type="BINDATA" />
468 <include name="IDR_SAD_FACE_ICON" file="resources\media_router\elements\ icon\sad-face.png" type="BINDATA" />
mark a. foltz 2015/03/23 17:49:57 Does this have a 2X version?
apacible 2015/03/23 18:22:48 Not at the moment. I'll talk to Jonny about that.
469 <include name="IDR_UNMUTE_ICON" file="resources\media_router\elements\ic on\unmute.png" type="BINDATA" />
470 <include name="IDR_UNMUTE_2X_ICON" file="resources\media_router\elements \icon\unmute2x.png" type="BINDATA" />
471 </if>
450 </includes> 472 </includes>
451 </release> 473 </release>
452 </grit> 474 </grit>
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/media_router/elements/icon/chromecast-icon-16.png » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698