GuestView constants are now frozen (and thus actually constant).

GuestView constants are now frozen (and thus actually constant).

BUG=466136
Committed: https://crrev.com/eedced79d7549dd8bf50ecd2c5f446a3de2f130a
Cr-Commit-Position: refs/heads/master@{#321594}

[paulmeyer, 2015-03-20 15:51:43]

Patchset #1 (id:1) has been deleted

[paulmeyer, 2015-03-20 15:52:10]

paulmeyer@chromium.org changed reviewers:
+ fsamuel@chromium.org

[paulmeyer, 2015-03-20 15:52:11]

+fsamuel@

[Fady Samuel, 2015-03-20 15:57:27]

https://codereview.chromium.org/1028503003/diff/20001/extensions/renderer/res...
File
extensions/renderer/resources/guest_view/extension_view/extension_view_constants.js
(right):

https://codereview.chromium.org/1028503003/diff/20001/extensions/renderer/res...
extensions/renderer/resources/guest_view/extension_view/extension_view_constants.js:16:
exports.ExtensionViewConstants = ExtensionViewConstants;
You can save a couple of lines of code:

exports.ExtensionViewConstants = $Object.freeze(ExtensionViewConstants);

https://codereview.chromium.org/1028503003/diff/20001/extensions/renderer/res...
File extensions/renderer/resources/guest_view/web_view/web_view_constants.js
(left):

https://codereview.chromium.org/1028503003/diff/20001/extensions/renderer/res...
extensions/renderer/resources/guest_view/web_view/web_view_constants.js:43:
exports.WebViewConstants = WebViewConstants;
You can save a couple of lines of code:

exports.WebViewContants = $Object.freeze(WebViewConstants);

https://codereview.chromium.org/1028503003/diff/20001/extensions/renderer/res...
File extensions/renderer/resources/guest_view/web_view/web_view_constants.js
(right):

https://codereview.chromium.org/1028503003/diff/20001/extensions/renderer/res...
extensions/renderer/resources/guest_view/web_view/web_view_constants.js:43:
Object.freeze(WebViewConstants);
nit: $Object

[paulmeyer, 2015-03-20 16:16:15]

ptal

https://codereview.chromium.org/1028503003/diff/20001/extensions/renderer/res...
File
extensions/renderer/resources/guest_view/extension_view/extension_view_constants.js
(right):

https://codereview.chromium.org/1028503003/diff/20001/extensions/renderer/res...
extensions/renderer/resources/guest_view/extension_view/extension_view_constants.js:16:
exports.ExtensionViewConstants = ExtensionViewConstants;
On 2015/03/20 15:57:27, Fady Samuel wrote:
> You can save a couple of lines of code:
> 
> exports.ExtensionViewConstants = $Object.freeze(ExtensionViewConstants);

Done.

https://codereview.chromium.org/1028503003/diff/20001/extensions/renderer/res...
File extensions/renderer/resources/guest_view/web_view/web_view_constants.js
(left):

https://codereview.chromium.org/1028503003/diff/20001/extensions/renderer/res...
extensions/renderer/resources/guest_view/web_view/web_view_constants.js:43:
exports.WebViewConstants = WebViewConstants;
On 2015/03/20 15:57:27, Fady Samuel wrote:
> You can save a couple of lines of code:
> 
> exports.WebViewContants = $Object.freeze(WebViewConstants);

Done.

https://codereview.chromium.org/1028503003/diff/20001/extensions/renderer/res...
File extensions/renderer/resources/guest_view/web_view/web_view_constants.js
(right):

https://codereview.chromium.org/1028503003/diff/20001/extensions/renderer/res...
extensions/renderer/resources/guest_view/web_view/web_view_constants.js:43:
Object.freeze(WebViewConstants);
On 2015/03/20 15:57:27, Fady Samuel wrote:
> nit: $Object

Actually, $Object.freeze doesn't exist. I tried that first and then took the '$'
off. I forgot to take it off the one in extension_view_constants.js though. I've
done that too now.

[paulmeyer, 2015-03-20 16:28:15]

ptal

[Fady Samuel, 2015-03-20 16:31:29]

lgtm

[paulmeyer, 2015-03-20 16:32:28]

paulmeyer@chromium.org changed reviewers:
+ kalman@chromium.org

[paulmeyer, 2015-03-20 16:32:29]

+kalman@ for safe_builtins.cc

[not at google - send to devlin, 2015-03-20 16:38:09]

lgtm

[paulmeyer, 2015-03-20 16:38:25]

The CQ bit was checked by paulmeyer@chromium.org

[commit-bot: I haz the power, 2015-03-20 16:39:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1028503003/60001

[commit-bot: I haz the power, 2015-03-20 17:49:10]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-03-20 17:50:35]

Patchset 3 (id:??) landed as
https://crrev.com/eedced79d7549dd8bf50ecd2c5f446a3de2f130a
Cr-Commit-Position: refs/heads/master@{#321594}