extensions/renderer/safe_builtins.cc - Issue 1028503003: GuestView constants are now frozen (and thus actually constant).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/safe_builtins.cc

Issue 1028503003: GuestView constants are now frozen (and thus actually constant). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added 'Object.freeze' to safe_builtins.cc Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/renderer/safe_builtins.cc

diff --git a/extensions/renderer/safe_builtins.cc b/extensions/renderer/safe_builtins.cc

index 2f0bf3c3ccd52f5f9a9686684e810b169e5990c7..c7296b7391c082326a05eb9cb4fd355b64f575d6 100644

--- a/extensions/renderer/safe_builtins.cc

+++ b/extensions/renderer/safe_builtins.cc

@@ -66,8 +66,8 @@ const char kScript[] =

"// Save only what is needed by the extension modules.\n"

"saveBuiltin(Object,\n"

" ['hasOwnProperty'],\n"

- " ['create', 'defineProperty', 'getOwnPropertyDescriptor',\n"

- " 'getPrototypeOf', 'keys']);\n"

+ " ['create', 'defineProperty', 'freeze',\n"

+ " 'getOwnPropertyDescriptor', 'getPrototypeOf', 'keys']);\n"

"saveBuiltin(Function,\n"

" ['apply', 'bind', 'call']);\n"

"saveBuiltin(Array,\n"

« no previous file with comments | « extensions/renderer/resources/guest_view/web_view/web_view_constants.js ('k') | no next file » | no next file with comments »