chrome/browser/ui/views/passwords/manage_passwords_icon_view.h - Issue 1028243004: Hide the password bubble when the underlying ManagePasswordsUIController changes its state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_icon_view.h

Issue 1028243004: Hide the password bubble when the underlying ManagePasswordsUIController changes its state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add a Mac test Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc ('k') | chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/passwords/manage_passwords_icon_view.h

diff --git a/chrome/browser/ui/views/passwords/manage_passwords_icon_view.h b/chrome/browser/ui/views/passwords/manage_passwords_icon_view.h

index 7004a8458d9fafc7aa438127e0c50d4af51af801..2d0c3d0bbec584086fd1e6a907010aaabeaf9a27 100644

--- a/chrome/browser/ui/views/passwords/manage_passwords_icon_view.h

+++ b/chrome/browser/ui/views/passwords/manage_passwords_icon_view.h

@@ -38,6 +38,7 @@ class ManagePasswordsIconView : public ManagePasswordsIcon,

protected:

// ManagePasswordsIcon:

void UpdateVisibleUI() override;

+ void OnChangingState() override;

private: