Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2149)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_icon.h

Issue 1028243004: Hide the password bubble when the underlying ManagePasswordsUIController changes its state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add a Mac test Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_icon.h
diff --git a/chrome/browser/ui/passwords/manage_passwords_icon.h b/chrome/browser/ui/passwords/manage_passwords_icon.h
index 165374075da3b098742a3f6df8defcd96e47333f..d4760d42551bae34c44c0e95a74adf679139c747 100644
--- a/chrome/browser/ui/passwords/manage_passwords_icon.h
+++ b/chrome/browser/ui/passwords/manage_passwords_icon.h
@@ -28,10 +28,13 @@ class ManagePasswordsIcon {
ManagePasswordsIcon();
~ManagePasswordsIcon();
- // Called from SetState() iff the icon's state has changed in order to do
- // whatever platform-specific UI work is necessary given the new state.
+ // Called from SetState() and SetActive() in order to do whatever
+ // platform-specific UI work is necessary.
virtual void UpdateVisibleUI() = 0;
+ // Called from SetState() iff the icon's state has changed.
+ virtual void OnChangingState() = 0;
+
private:
// Updates the resource IDs in response to state changes.
void UpdateIDs();

Powered by Google App Engine
This is Rietveld 408576698