chrome/browser/ui/passwords/manage_passwords_icon.cc - Issue 1028243004: Hide the password bubble when the underlying ManagePasswordsUIController changes its state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_icon.cc

Issue 1028243004: Hide the password bubble when the underlying ManagePasswordsUIController changes its state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add a Mac test Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_icon.h ('k') | chrome/browser/ui/passwords/manage_passwords_icon_mock.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_icon.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_icon.cc b/chrome/browser/ui/passwords/manage_passwords_icon.cc

index cbe2855e812976e1ffaeaa06f7c5874061e33c89..6ebdda84322c5f122f743be33f7555d24ea0c6b0 100644

--- a/chrome/browser/ui/passwords/manage_passwords_icon.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_icon.cc

@@ -28,6 +28,7 @@ void ManagePasswordsIcon::SetActive(bool active) {

void ManagePasswordsIcon::SetState(password_manager::ui::State state) {

if (state_ == state)

return;

+ OnChangingState();

state_ = state;

UpdateIDs();

UpdateVisibleUI();

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_icon.h ('k') | chrome/browser/ui/passwords/manage_passwords_icon_mock.h » ('j') | no next file with comments »