Issue 1028183003: Pass segment to decomposeArcToCubic and let it handle exceptional cases

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1028183003: Pass segment to decomposeArcToCubic and let it handle exceptional cases (Closed)

Created:
5 years, 9 months ago by fs

Modified:
5 years, 9 months ago

Reviewers:
pdr., f(malita), kouhei (in TOK)

CC:
blink-reviews, krit, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Pass segment to decomposeArcToCubic and let it handle exceptional cases Moves complexity from SVGPathParser::emitArcToSegment, and leaves it doing just normalization and emittal. BUG=467592 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192398

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -24 lines)			Patch
	M	Source/core/svg/SVGPathParser.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/core/svg/SVGPathParser.cpp	View		4 chunks	+22 lines, -23 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1028183003/1

5 years, 9 months ago (2015-03-24 01:21:39 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-24 01:25:13 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192398

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages