Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: Source/core/svg/SVGPathParser.h

Issue 1028183003: Pass segment to decomposeArcToCubic and let it handle exceptional cases (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/svg/SVGPathParser.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2002, 2003 The Karbon Developers 2 * Copyright (C) 2002, 2003 The Karbon Developers
3 * Copyright (C) 2006 Alexander Kellett <lypanov@kde.org> 3 * Copyright (C) 2006 Alexander Kellett <lypanov@kde.org>
4 * Copyright (C) 2006, 2007 Rob Buis <buis@kde.org> 4 * Copyright (C) 2006, 2007 Rob Buis <buis@kde.org>
5 * Copyright (C) 2007, 2009 Apple Inc. All rights reserved. 5 * Copyright (C) 2007, 2009 Apple Inc. All rights reserved.
6 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 6 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 ASSERT(m_source); 42 ASSERT(m_source);
43 ASSERT(m_consumer); 43 ASSERT(m_consumer);
44 } 44 }
45 45
46 bool parsePathDataFromSource(PathParsingMode, bool checkForInitialMoveTo = t rue); 46 bool parsePathDataFromSource(PathParsingMode, bool checkForInitialMoveTo = t rue);
47 47
48 DECLARE_TRACE(); 48 DECLARE_TRACE();
49 49
50 private: 50 private:
51 bool initialCommandIsMoveTo(); 51 bool initialCommandIsMoveTo();
52 bool decomposeArcToCubic(float, float, float, const FloatPoint&, const Float Point&, bool largeArcFlag, bool sweepFlag); 52 bool decomposeArcToCubic(const FloatPoint& currentPoint, const PathSegmentDa ta&);
53 void emitMoveToSegment(PathSegmentData&); 53 void emitMoveToSegment(PathSegmentData&);
54 void emitLineToSegment(PathSegmentData&); 54 void emitLineToSegment(PathSegmentData&);
55 void emitLineToHorizontalSegment(PathSegmentData&); 55 void emitLineToHorizontalSegment(PathSegmentData&);
56 void emitLineToVerticalSegment(PathSegmentData&); 56 void emitLineToVerticalSegment(PathSegmentData&);
57 void emitCurveToCubicSegment(PathSegmentData&); 57 void emitCurveToCubicSegment(PathSegmentData&);
58 void emitCurveToCubicSmoothSegment(PathSegmentData&); 58 void emitCurveToCubicSmoothSegment(PathSegmentData&);
59 void emitCurveToQuadraticSegment(PathSegmentData&); 59 void emitCurveToQuadraticSegment(PathSegmentData&);
60 void emitCurveToQuadraticSmoothSegment(PathSegmentData&); 60 void emitCurveToQuadraticSmoothSegment(PathSegmentData&);
61 void emitArcToSegment(PathSegmentData&); 61 void emitArcToSegment(PathSegmentData&);
62 62
63 RawPtrWillBeMember<SVGPathSource> m_source; 63 RawPtrWillBeMember<SVGPathSource> m_source;
64 RawPtrWillBeMember<SVGPathConsumer> m_consumer; 64 RawPtrWillBeMember<SVGPathConsumer> m_consumer;
65 PathCoordinateMode m_mode; 65 PathCoordinateMode m_mode;
66 SVGPathSegType m_lastCommand; 66 SVGPathSegType m_lastCommand;
67 FloatPoint m_controlPoint; 67 FloatPoint m_controlPoint;
68 FloatPoint m_currentPoint; 68 FloatPoint m_currentPoint;
69 FloatPoint m_subPathPoint; 69 FloatPoint m_subPathPoint;
70 }; 70 };
71 71
72 } // namespace blink 72 } // namespace blink
73 73
74 #endif // SVGPathParser_h 74 #endif // SVGPathParser_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/svg/SVGPathParser.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698