components/autofill/core/browser/autofill_driver.h - Issue 1028163002: Processing USERNAME reply from Autofill server in Password Manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_driver.h

Issue 1028163002: Processing USERNAME reply from Autofill server in Password Manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed many reviewer comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/renderer/password_form_conversion_utils.cc ('K') | « components/autofill/core/browser/autofill_client.h ('k') | components/autofill/core/browser/autofill_manager.cc » ('j') | components/autofill/core/browser/autofill_metrics.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_driver.h

diff --git a/components/autofill/core/browser/autofill_driver.h b/components/autofill/core/browser/autofill_driver.h

index 368f1f47f812e192288a879634389a59616332d3..df87f63176e9feb4ed1fbd8a1a11d406183a5065 100644

--- a/components/autofill/core/browser/autofill_driver.h

+++ b/components/autofill/core/browser/autofill_driver.h

@@ -61,9 +61,9 @@ class AutofillDriver {

// Pings renderer. The renderer will return an IPC acknowledging the ping.

virtual void PingRenderer() = 0;

- // Pass the form structures to the password generation manager to detect

- // account creation forms.

- virtual void DetectAccountCreationForms(

+ // Pass the form structures to the password manager to choose correct username

+ // and to the password generation manager to detect account creation forms.

+ virtual void PropagateAutofillPredictions(

const std::vector<autofill::FormStructure*>& forms) = 0;

// Sends the field type predictions specified in |forms| to the renderer. This