components/autofill/content/renderer/password_generation_agent.cc - Issue 1028163002: Processing USERNAME reply from Autofill server in Password Manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_generation_agent.cc

Issue 1028163002: Processing USERNAME reply from Autofill server in Password Manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed many reviewer comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/renderer/password_form_conversion_utils.cc ('K') | « components/autofill/content/renderer/password_form_conversion_utils.cc ('k') | components/autofill/core/browser/autofill_client.h » ('j') | components/autofill/core/browser/autofill_metrics.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/password_generation_agent.cc

diff --git a/components/autofill/content/renderer/password_generation_agent.cc b/components/autofill/content/renderer/password_generation_agent.cc

index c5a7beef2af4642ef7266066a2226af760eb713a..a7acf25abd5a3686e7b93156c0f7e4e3f4951daa 100644

--- a/components/autofill/content/renderer/password_generation_agent.cc

+++ b/components/autofill/content/renderer/password_generation_agent.cc

@@ -187,7 +187,7 @@ void PasswordGenerationAgent::FindPossibleGenerationForm() {

// If we can't get a valid PasswordForm, we skip this form because the

// the password won't get saved even if we generate it.

scoped_ptr<PasswordForm> password_form(

- CreatePasswordForm(forms[i], nullptr));

+ CreatePasswordForm(forms[i], nullptr, nullptr));

if (!password_form.get()) {

VLOG(2) << "Skipping form as it would not be saved";

continue;