Processing USERNAME reply from Autofill server in Password Manager

components/autofill/content/renderer/password_form_conversion_utils.h

Index: components/autofill/content/renderer/password_form_conversion_utils.h
diff --git a/components/autofill/content/renderer/password_form_conversion_utils.h b/components/autofill/content/renderer/password_form_conversion_utils.h
index d5fa13fa91447a2ac42fd03742ad5b60f07bbaa5..e5595ed5b1f6ba71e20a943036064a0ebb282b34 100644
--- a/components/autofill/content/renderer/password_form_conversion_utils.h
+++ b/components/autofill/content/renderer/password_form_conversion_utils.h
@@ -17,6 +17,8 @@ class WebString;
 
 namespace autofill {
 
+struct FormData;
+struct FormFieldData;
 struct PasswordForm;
 
 // Create a PasswordForm from DOM form. Webkit doesn't allow storing
@@ -26,10 +28,14 @@ struct PasswordForm;
 // If an element of |form| has an entry in |nonscript_modified_values|, the
 // associated string is used instead of the element's value to create
 // the PasswordForm.
+// |form_predictions| is Autofill server response, if present it's used for
+// overwriting default username element selection.
 scoped_ptr<PasswordForm> CreatePasswordForm(
     const blink::WebFormElement& form,
     const std::map<const blink::WebInputElement, blink::WebString>*
-        nonscript_modified_values);
+        nonscript_modified_values,
+    const std::map<autofill::FormData, autofill::FormFieldData>*
+        form_predictions);

[Ilya Sherman, 2015/03/26 00:30:04]

Please pass this by const-reference.

[vabr (Chromium), 2015/03/26 09:43:55]

Ilya -- I believe the pointer was used to allow specifying no predictions easily
by nullptr (see, e.g.,
components/autofill/content/renderer/password_generation_agent.cc). Do you
object to that?

 
 }  // namespace autofill