Processing USERNAME reply from Autofill server in Password Manager

components/autofill/content/renderer/password_form_conversion_utils.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_FORM_CONVERSION_UTILS_H_
 #define COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_FORM_CONVERSION_UTILS_H_
 
 #include <map>
 
 #include "base/memory/scoped_ptr.h"
 
 namespace blink {
 class WebFormElement;
 class WebInputElement;
 class WebString;
 }
 
 namespace autofill {
 
+struct FormData;
+struct FormFieldData;
 struct PasswordForm;
 
 // Create a PasswordForm from DOM form. Webkit doesn't allow storing
 // custom metadata to DOM nodes, so we have to do this every time an event
 // happens with a given form and compare against previously Create'd forms
 // to identify..which sucks.
 // If an element of |form| has an entry in |nonscript_modified_values|, the
 // associated string is used instead of the element's value to create
 // the PasswordForm.
+// |form_predictions| is Autofill server response, if present it's used for
+// overwriting default username element selection.
 scoped_ptr<PasswordForm> CreatePasswordForm(
     const blink::WebFormElement& form,
     const std::map<const blink::WebInputElement, blink::WebString>*
-        nonscript_modified_values);
+        nonscript_modified_values,
+    const std::map<autofill::FormData, autofill::FormFieldData>*
+        form_predictions);

[Ilya Sherman, 2015/03/26 00:30:04]

Please pass this by const-reference.

[vabr (Chromium), 2015/03/26 09:43:55]

Ilya -- I believe the pointer was used to allow specifying no predictions easily
by nullptr (see, e.g.,
components/autofill/content/renderer/password_generation_agent.cc). Do you
object to that?

 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_FORM_CONVERSION_UTILS_H__