components/password_manager/core/browser/password_manager_driver.h - Issue 1028163002: Processing USERNAME reply from Autofill server in Password Manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager_driver.h

Issue 1028163002: Processing USERNAME reply from Autofill server in Password Manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reviewer's comments addressed Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/password_form_manager.cc ('K') | « components/password_manager/core/browser/password_manager.cc ('k') | components/password_manager/core/browser/password_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager_driver.h

diff --git a/components/password_manager/core/browser/password_manager_driver.h b/components/password_manager/core/browser/password_manager_driver.h

index 74e344430ff2b2d87aae5aa2e4834187ef73d2a8..4b105905145912c6cbd2833a4ac7af5464526f11 100644

--- a/components/password_manager/core/browser/password_manager_driver.h

+++ b/components/password_manager/core/browser/password_manager_driver.h

@@ -14,6 +14,7 @@

namespace autofill {

class AutofillManager;

struct FormData;

+struct FormDataPredictions;

struct PasswordForm;

struct PasswordFormFillData;

} // namespace autofill

@@ -44,6 +45,10 @@ class PasswordManagerDriver

virtual void AccountCreationFormsFound(

const std::vector<autofill::FormData>& forms) = 0;

+ // Notifies the driver that account creation |forms| were found.

+ virtual void AutofillDataReceived(

+ const std::vector<autofill::FormDataPredictions>& forms) {}

// Notifies the driver that the user has accepted a generated password.

virtual void GeneratedPasswordAccepted(const base::string16& password) = 0;