Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 1028163002: Processing USERNAME reply from Autofill server in Password Manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reviewer's comments addressed Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager.cc
diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc
index 3d6111c7e6ef1c33c0a48a895906ca0b255cfabe..91355a7182cdf4f10c9cca496feb9977f5ce6593 100644
--- a/components/password_manager/core/browser/password_manager.cc
+++ b/components/password_manager/core/browser/password_manager.cc
@@ -11,6 +11,9 @@
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
#include "base/threading/platform_thread.h"
+#include "components/autofill/core/browser/autofill_field.h"
+#include "components/autofill/core/browser/form_structure.h"
+#include "components/autofill/core/common/form_data_predictions.h"
#include "components/password_manager/core/browser/browser_save_password_progress_logger.h"
#include "components/password_manager/core/browser/password_autofill_manager.h"
#include "components/password_manager/core/browser/password_form_manager.h"
@@ -718,4 +721,28 @@ void PasswordManager::Autofill(password_manager::PasswordManagerDriver* driver,
client_->PasswordWasAutofilled(best_matches);
}
+void PasswordManager::ProcessAutofillPredictions(
+ password_manager::PasswordManagerDriver* driver,
+ const std::vector<autofill::FormStructure*>& forms) {
+ // Leave only forms that contain fields that are useful for password manager.
+ std::vector<autofill::FormStructure*> forms_to_send;
+ for (auto form : forms) {
+ bool is_intesting_field_found = false;
+ for (auto it = form->begin(); it != form->end(); ++it) {
+ if ((*it)->server_type() == autofill::USERNAME ||
+ (*it)->server_type() == autofill::USERNAME_AND_EMAIL_ADDRESS) {
+ is_intesting_field_found = true;
+ break;
+ }
+ }
+ if (is_intesting_field_found)
+ forms_to_send.push_back(form);
+ }
+ if (forms_to_send.empty())
+ return;
+ std::vector<autofill::FormDataPredictions> predictions =
+ autofill::FormStructure::GetFieldTypePredictions(forms_to_send);
+ driver->AutofillDataReceived(predictions);
+}
+
} // namespace password_manager

Powered by Google App Engine
This is Rietveld 408576698