Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 1028073002: X87: Simplify pending message object handling. (Closed)

Created:
5 years, 9 months ago by chunyang.dai
Modified:
5 years, 9 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Simplify pending message object handling. port d4696c484142c601cbd691ae80164043785a3af7 (r27150) original commit message: This moves the decision whether to report a message or not to when the pending exception is propagated instead of trying to preserve the decision in a ThreadLocalTop field. BUG= Committed: https://crrev.com/f8c4c12728e5f33ed8462b5c90a2d404833cac80 Cr-Commit-Position: refs/heads/master@{#27360}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M src/x87/full-codegen-x87.cc View 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL.
5 years, 9 months ago (2015-03-23 09:44:28 UTC) #2
Weiliang
lgtm
5 years, 9 months ago (2015-03-23 09:49:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1028073002/1
5 years, 9 months ago (2015-03-23 09:49:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-23 10:21:09 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 10:21:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f8c4c12728e5f33ed8462b5c90a2d404833cac80
Cr-Commit-Position: refs/heads/master@{#27360}

Powered by Google App Engine
This is Rietveld 408576698