Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: src/x87/full-codegen-x87.cc

Issue 1028073002: X87: Simplify pending message object handling. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X87 7 #if V8_TARGET_ARCH_X87
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 5219 matching lines...) Expand 10 before | Expand all | Expand 10 after
5230 __ push(edx); 5230 __ push(edx);
5231 5231
5232 // Store result register while executing finally block. 5232 // Store result register while executing finally block.
5233 __ push(result_register()); 5233 __ push(result_register());
5234 5234
5235 // Store pending message while executing finally block. 5235 // Store pending message while executing finally block.
5236 ExternalReference pending_message_obj = 5236 ExternalReference pending_message_obj =
5237 ExternalReference::address_of_pending_message_obj(isolate()); 5237 ExternalReference::address_of_pending_message_obj(isolate());
5238 __ mov(edx, Operand::StaticVariable(pending_message_obj)); 5238 __ mov(edx, Operand::StaticVariable(pending_message_obj));
5239 __ push(edx); 5239 __ push(edx);
5240
5241 ExternalReference has_pending_message =
5242 ExternalReference::address_of_has_pending_message(isolate());
5243 __ mov(edx, Operand::StaticVariable(has_pending_message));
5244 __ SmiTag(edx);
5245 __ push(edx);
5246 } 5240 }
5247 5241
5248 5242
5249 void FullCodeGenerator::ExitFinallyBlock() { 5243 void FullCodeGenerator::ExitFinallyBlock() {
5250 DCHECK(!result_register().is(edx)); 5244 DCHECK(!result_register().is(edx));
5251 // Restore pending message from stack. 5245 // Restore pending message from stack.
5252 __ pop(edx); 5246 __ pop(edx);
5253 __ SmiUntag(edx);
5254 ExternalReference has_pending_message =
5255 ExternalReference::address_of_has_pending_message(isolate());
5256 __ mov(Operand::StaticVariable(has_pending_message), edx);
5257
5258 __ pop(edx);
5259 ExternalReference pending_message_obj = 5247 ExternalReference pending_message_obj =
5260 ExternalReference::address_of_pending_message_obj(isolate()); 5248 ExternalReference::address_of_pending_message_obj(isolate());
5261 __ mov(Operand::StaticVariable(pending_message_obj), edx); 5249 __ mov(Operand::StaticVariable(pending_message_obj), edx);
5262 5250
5263 // Restore result register from stack. 5251 // Restore result register from stack.
5264 __ pop(result_register()); 5252 __ pop(result_register());
5265 5253
5266 // Uncook return address. 5254 // Uncook return address.
5267 __ pop(edx); 5255 __ pop(edx);
5268 __ SmiUntag(edx); 5256 __ SmiUntag(edx);
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
5374 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(), 5362 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(),
5375 Assembler::target_address_at(call_target_address, 5363 Assembler::target_address_at(call_target_address,
5376 unoptimized_code)); 5364 unoptimized_code));
5377 return OSR_AFTER_STACK_CHECK; 5365 return OSR_AFTER_STACK_CHECK;
5378 } 5366 }
5379 5367
5380 5368
5381 } } // namespace v8::internal 5369 } } // namespace v8::internal
5382 5370
5383 #endif // V8_TARGET_ARCH_X87 5371 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698