Issue 102803003: A simple draw() function in Javascript.

Issue 102803003: A simple draw() function in Javascript. (Closed)

Created:
7 years ago by jcgregorio

Modified:
7 years ago

Reviewers:
robertphillips

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

A simple draw() function in Javascript. Committed: http://code.google.com/p/skia/source/detail?r=12527

Patch Set 3 : clean up. #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+163 lines, -24 lines)			Patch
	M	experimental/SkV8Example/SkV8Example.h	View		1 chunk	+15 lines, -1 line	0 comments	Download
	M	experimental/SkV8Example/SkV8Example.cpp	View	1 2	3 chunks	+148 lines, -23 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm https://codereview.chromium.org/102803003/diff/20001/experimental/SkV8Example/SkV8Example.cpp File experimental/SkV8Example/SkV8Example.cpp (right): https://codereview.chromium.org/102803003/diff/20001/experimental/SkV8Example/SkV8Example.cpp#newcode93 experimental/SkV8Example/SkV8Example.cpp:93: The V8 wrapping process seems to require globals ...

7 years ago (2013-12-06 13:32:42 UTC) #2

jcgregorio

https://codereview.chromium.org/102803003/diff/20001/experimental/SkV8Example/SkV8Example.cpp File experimental/SkV8Example/SkV8Example.cpp (right): https://codereview.chromium.org/102803003/diff/20001/experimental/SkV8Example/SkV8Example.cpp#newcode93 experimental/SkV8Example/SkV8Example.cpp:93: On 2013/12/06 13:32:42, robertphillips wrote: > The V8 wrapping ...

7 years ago (2013-12-06 13:40:22 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/102803003/40001

7 years ago (2013-12-06 15:17:03 UTC) #4

Message was sent while issue was closed.

Change committed as 12527

Expand Messages | Collapse Messages