Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1027753002: [turbofan] Fix lowering of Math.max for integral inputs. (Closed)

Created:
5 years, 9 months ago by Benedikt Meurer
Modified:
5 years, 9 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix lowering of Math.max for integral inputs. R=jarin@chromium.org BUG=chromium:468162 LOG=y Committed: https://crrev.com/ff89876bb9d362ea4d53d5ee49346d617ee1f5f6 Cr-Commit-Position: refs/heads/master@{#27341}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M src/compiler/js-builtin-reducer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + test/mjsunit/compiler/regress-468162.js View 1 chunk +6 lines, -7 lines 0 comments Download
M test/unittests/compiler/js-builtin-reducer-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 9 months ago (2015-03-20 11:42:30 UTC) #1
Benedikt Meurer
PTAL
5 years, 9 months ago (2015-03-20 11:42:42 UTC) #2
Jarin
lgtm. (How about writing some more tests for min & max?)
5 years, 9 months ago (2015-03-20 11:45:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1027753002/1
5 years, 9 months ago (2015-03-20 11:45:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-20 12:05:12 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 12:05:31 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff89876bb9d362ea4d53d5ee49346d617ee1f5f6
Cr-Commit-Position: refs/heads/master@{#27341}

Powered by Google App Engine
This is Rietveld 408576698