Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Side by Side Diff: src/compiler/js-builtin-reducer.cc

Issue 1027753002: [turbofan] Fix lowering of Math.max for integral inputs. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | test/mjsunit/compiler/regress-468162.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/diamond.h" 5 #include "src/compiler/diamond.h"
6 #include "src/compiler/js-builtin-reducer.h" 6 #include "src/compiler/js-builtin-reducer.h"
7 #include "src/compiler/js-graph.h" 7 #include "src/compiler/js-graph.h"
8 #include "src/compiler/node-matchers.h" 8 #include "src/compiler/node-matchers.h"
9 #include "src/compiler/node-properties.h" 9 #include "src/compiler/node-properties.h"
10 #include "src/types.h" 10 #include "src/types.h"
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 // Math.max(a:number) -> a 111 // Math.max(a:number) -> a
112 return Replace(r.left()); 112 return Replace(r.left());
113 } 113 }
114 if (r.InputsMatchAll(Type::Integral32())) { 114 if (r.InputsMatchAll(Type::Integral32())) {
115 // Math.max(a:int32, b:int32, ...) 115 // Math.max(a:int32, b:int32, ...)
116 Node* value = r.GetJSCallInput(0); 116 Node* value = r.GetJSCallInput(0);
117 for (int i = 1; i < r.GetJSCallArity(); i++) { 117 for (int i = 1; i < r.GetJSCallArity(); i++) {
118 Node* const input = r.GetJSCallInput(i); 118 Node* const input = r.GetJSCallInput(i);
119 value = graph()->NewNode( 119 value = graph()->NewNode(
120 common()->Select(kMachNone), 120 common()->Select(kMachNone),
121 graph()->NewNode(simplified()->NumberLessThan(), input, value), input, 121 graph()->NewNode(simplified()->NumberLessThan(), input, value), value,
122 value); 122 input);
123 } 123 }
124 return Replace(value); 124 return Replace(value);
125 } 125 }
126 return NoChange(); 126 return NoChange();
127 } 127 }
128 128
129 129
130 // ES6 draft 08-24-14, section 20.2.2.19. 130 // ES6 draft 08-24-14, section 20.2.2.19.
131 Reduction JSBuiltinReducer::ReduceMathImul(Node* node) { 131 Reduction JSBuiltinReducer::ReduceMathImul(Node* node) {
132 JSCallReduction r(node); 132 JSCallReduction r(node);
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
179 } 179 }
180 180
181 181
182 MachineOperatorBuilder* JSBuiltinReducer::machine() const { 182 MachineOperatorBuilder* JSBuiltinReducer::machine() const {
183 return jsgraph()->machine(); 183 return jsgraph()->machine();
184 } 184 }
185 185
186 } // namespace compiler 186 } // namespace compiler
187 } // namespace internal 187 } // namespace internal
188 } // namespace v8 188 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/compiler/regress-468162.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698