Web MIDI Linux: Omit empty values in JSON, to make id generation more robust

Web MIDI Linux: Omit empty values in JSON, to make id generation more robust

Committed: https://crrev.com/7135be17e5eecd2eb320b0417799a8d8e57a4305
Cr-Commit-Position: refs/heads/master@{#321922}

[Adam Goode, 2015-03-22 03:48:45]

agoode@chromium.org changed reviewers:
+ toyoshim@chromium.org

[Takashi Toyoshima, 2015-03-23 06:17:11]

lgtm with one optional suggestion.

https://codereview.chromium.org/1027643003/diff/1/media/midi/midi_manager_als...
File media/midi/midi_manager_alsa.cc (right):

https://codereview.chromium.org/1027643003/diff/1/media/midi/midi_manager_als...
media/midi/midi_manager_alsa.cc:405: base::DictionaryValue* value = new
base::DictionaryValue();
This is not introduced by this CL, but it's better to keep |value| as a
scoped_ptr here.

405: scoped_ptr<base::DictionaryValue> value(new base::DictionaryValue);
406: SetStringIfNonEmpty(value.get(), "path", path_);
...
427: return value.Pass();

[Adam Goode, 2015-03-23 23:09:44]

On 2015/03/23 06:17:11, Takashi Toyoshima (chromium) wrote:
> lgtm with one optional suggestion.
> 
>
https://codereview.chromium.org/1027643003/diff/1/media/midi/midi_manager_als...
> File media/midi/midi_manager_alsa.cc (right):
> 
>
https://codereview.chromium.org/1027643003/diff/1/media/midi/midi_manager_als...
> media/midi/midi_manager_alsa.cc:405: base::DictionaryValue* value = new
> base::DictionaryValue();
> This is not introduced by this CL, but it's better to keep |value| as a
> scoped_ptr here.
> 
> 405: scoped_ptr<base::DictionaryValue> value(new base::DictionaryValue);
> 406: SetStringIfNonEmpty(value.get(), "path", path_);
> ...
> 427: return value.Pass();

Thanks. I didn't see that I could do this through a scoped_ptr.

[Adam Goode, 2015-03-24 01:23:41]

The CQ bit was checked by agoode@chromium.org

[Adam Goode, 2015-03-24 01:23:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
toyoshim@chromium.org
Link to the patchset: https://codereview.chromium.org/1027643003/#ps20001
(title: "Improve use of scoped_ptr in AlsaPortMetadata::Value()")

[commit-bot: I haz the power, 2015-03-24 01:24:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1027643003/20001

[commit-bot: I haz the power, 2015-03-24 01:48:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-24 01:49:00]

Patchset 2 (id:??) landed as
https://crrev.com/7135be17e5eecd2eb320b0417799a8d8e57a4305
Cr-Commit-Position: refs/heads/master@{#321922}