Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Unified Diff: media/midi/midi_manager_alsa_unittest.cc

Issue 1027643003: Web MIDI Linux: Omit empty values in JSON, to make id generation more robust (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@h3
Patch Set: Improve use of scoped_ptr in AlsaPortMetadata::Value() Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/midi/midi_manager_alsa.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/midi/midi_manager_alsa_unittest.cc
diff --git a/media/midi/midi_manager_alsa_unittest.cc b/media/midi/midi_manager_alsa_unittest.cc
index 1a29334c9adab14cddf82e0b6dbeeb15c082b4dd..811b6356266ded71b5e0bfed69a5c03d689b67e5 100644
--- a/media/midi/midi_manager_alsa_unittest.cc
+++ b/media/midi/midi_manager_alsa_unittest.cc
@@ -74,6 +74,10 @@ TEST(MidiManagerAlsaTest, JSONPortMetadata) {
"path", "bus", "id", &address, "client_name", "port_name", "card_name",
"card_longname", MidiManagerAlsa::AlsaPortMetadata::Type::kOutput);
+ MidiManagerAlsa::AlsaPortMetadata partial(
+ "", "", "", &address, "client_name", "port_name", "card_name",
+ "card_longname", MidiManagerAlsa::AlsaPortMetadata::Type::kOutput);
+
ASSERT_EQ(
"{\"bus\":\"bus\",\"cardLongname\":\"card_longname\",\"cardName\":\"card_"
"name\","
@@ -94,6 +98,15 @@ TEST(MidiManagerAlsaTest, JSONPortMetadata) {
output.JSONValue());
ASSERT_EQ("747E553D40F8388A0C1C51261B82869D5EFA8A54860AAFB2F4F7437744982495",
output.OpaqueKey());
+
+ ASSERT_EQ(
+ "{\"cardLongname\":\"card_longname\",\"cardName\":\"card_"
+ "name\","
+ "\"clientAddr\":1,\"clientName\":\"client_name\","
+ "\"portAddr\":2,\"portName\":\"port_name\",\"type\":\"output\"}",
+ partial.JSONValue());
+ ASSERT_EQ("51DF7AF543B5BDF83C0B8DE3A00A0BC588DDFCA8600671EF7D59828B40DFF6D3",
+ partial.OpaqueKey());
}
} // namespace media
« no previous file with comments | « media/midi/midi_manager_alsa.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698