Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: sky/framework/components/fixed_height_scrollable.dart

Issue 1027633003: [Effen] Add AnimatedComponent base class (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: cr changes Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/framework/components/drawer.dart ('k') | sky/framework/components/ink_well.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/framework/components/fixed_height_scrollable.dart
diff --git a/sky/framework/components/fixed_height_scrollable.dart b/sky/framework/components/fixed_height_scrollable.dart
index 948a6dfc8813e0e6c139577fae59725b268102f1..500af2e27f6b73f9ce3bf73231eba97c69f55eeb 100644
--- a/sky/framework/components/fixed_height_scrollable.dart
+++ b/sky/framework/components/fixed_height_scrollable.dart
@@ -30,10 +30,11 @@ abstract class FixedHeightScrollable extends Scrollable {
FixedHeightScrollable({
Object key,
ScrollBehavior scrollBehavior
- }) : super(key: key, scrollBehavior: scrollBehavior);
+ }) : super(key: key, scrollBehavior: scrollBehavior) {
+ onDidMount(_measureHeights);
+ }
- void didMount() {
- super.didMount();
+ void _measureHeights() {
var root = getRoot();
var item = root.firstChild.firstChild;
sky.ClientRect scrollRect = root.getBoundingClientRect();
« no previous file with comments | « sky/framework/components/drawer.dart ('k') | sky/framework/components/ink_well.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698