Source/web/WebDevToolsFrontendImpl.cpp - Issue 1027593003: bindings: Use Maybe version of v8::String::NewFromUtf8()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebDevToolsFrontendImpl.cpp

Issue 1027593003: bindings: Use Maybe version of v8::String::NewFromUtf8() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebDevToolsFrontendImpl.cpp

diff --git a/Source/web/WebDevToolsFrontendImpl.cpp b/Source/web/WebDevToolsFrontendImpl.cpp

index 7cc3dec68ad527d9f89e144f1907a4423778c4ed..e65718b28912cdb2a8a244e516d9fd7c1d5681d9 100644

--- a/Source/web/WebDevToolsFrontendImpl.cpp

+++ b/Source/web/WebDevToolsFrontendImpl.cpp

@@ -85,7 +85,7 @@ void WebDevToolsFrontendImpl::didClearWindowObject(WebLocalFrameImpl* frame)

m_devtoolsHost = DevToolsHost::create(this, m_webFrame->frame());

v8::Handle<v8::Object> global = scriptState->context()->Global();

v8::Handle<v8::Value> devtoolsHostObj = toV8(m_devtoolsHost.get(), global, scriptState->isolate());

- global->Set(v8::String::NewFromUtf8(isolate, "DevToolsHost"), devtoolsHostObj);

+ global->Set(v8AtomicString(isolate, "DevToolsHost"), devtoolsHostObj);

}

if (m_injectedScriptForOrigin.isEmpty())