Source/web/tests/CustomEventTest.cpp - Issue 1027593003: bindings: Use Maybe version of v8::String::NewFromUtf8()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/CustomEventTest.cpp

Issue 1027593003: bindings: Use Maybe version of v8::String::NewFromUtf8() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/tests/CustomEventTest.cpp

diff --git a/Source/web/tests/CustomEventTest.cpp b/Source/web/tests/CustomEventTest.cpp

index 8e97a7083dbb3fd36a28ab154a80a296e17b6580..2f2ede41a00623fe688ecd24c8dacdfeffa89a05 100644

--- a/Source/web/tests/CustomEventTest.cpp

+++ b/Source/web/tests/CustomEventTest.cpp

@@ -67,7 +67,7 @@ public:

ScriptState::Scope scope(scriptState);

v8::Handle<v8::Value> jsEvent = toV8(event, scriptState->context()->Global(), isolate());

- EXPECT_EQ(jsEvent->ToObject(isolate())->Get(v8::String::NewFromUtf8(isolate(), "detail")), v8::Boolean::New(isolate(), true));

+ EXPECT_EQ(jsEvent->ToObject(isolate())->Get(v8AtomicString(isolate(), "detail")), v8::Boolean::New(isolate(), true));

}

static PassRefPtr<TestListener> create(ScriptState* scriptState)