Source/bindings/core/v8/ScriptValueSerializer.cpp - Issue 1027593003: bindings: Use Maybe version of v8::String::NewFromUtf8()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/ScriptValueSerializer.cpp

Issue 1027593003: bindings: Use Maybe version of v8::String::NewFromUtf8() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/ScriptValueSerializer.cpp

diff --git a/Source/bindings/core/v8/ScriptValueSerializer.cpp b/Source/bindings/core/v8/ScriptValueSerializer.cpp

index cb2e55b3526cb224890238a8de7419ccc03b3d03..185f6cd7e98d5b9a2aa70c5a8cb2daa7c8cf105c 100644

--- a/Source/bindings/core/v8/ScriptValueSerializer.cpp

+++ b/Source/bindings/core/v8/ScriptValueSerializer.cpp

@@ -1273,7 +1273,7 @@ bool SerializedScriptValueReader::readString(v8::Local<v8::Value>* value)

return false;

if (m_position + length > m_length)

return false;

- *value = v8::String::NewFromUtf8(isolate(), reinterpret_cast<const char*>(m_buffer + m_position), v8::String::kNormalString, length);

+ *value = v8NormalString(isolate(), reinterpret_cast<const char*>(m_buffer + m_position), length);

m_position += length;

return true;

}