Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: Source/bindings/core/v8/ScriptDebugServer.cpp

Issue 1027593003: bindings: Use Maybe version of v8::String::NewFromUtf8() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/ScriptDebugServer.cpp
diff --git a/Source/bindings/core/v8/ScriptDebugServer.cpp b/Source/bindings/core/v8/ScriptDebugServer.cpp
index d138fb953ff54f3b3cfb73317c8f67f798e4b18a..61d8c854a99820d82f6942ae6f38e38dfd585dc2 100644
--- a/Source/bindings/core/v8/ScriptDebugServer.cpp
+++ b/Source/bindings/core/v8/ScriptDebugServer.cpp
@@ -667,7 +667,7 @@ v8::Local<v8::Object> ScriptDebugServer::debuggerScriptLocal() const
v8::Local<v8::String> ScriptDebugServer::v8InternalizedString(const char* str) const
{
- return v8::String::NewFromUtf8(m_isolate, str, v8::String::kInternalizedString);
+ return v8AtomicString(m_isolate, str);
}
v8::Local<v8::Value> ScriptDebugServer::functionScopes(v8::Handle<v8::Function> function)
@@ -706,7 +706,7 @@ v8::Local<v8::Value> ScriptDebugServer::getInternalProperties(v8::Handle<v8::Obj
v8::Handle<v8::Value> ScriptDebugServer::setFunctionVariableValue(v8::Handle<v8::Value> functionValue, int scopeNumber, const String& variableName, v8::Handle<v8::Value> newValue)
{
if (m_debuggerScript.IsEmpty())
- return m_isolate->ThrowException(v8::String::NewFromUtf8(m_isolate, "Debugging is not enabled."));
+ return m_isolate->ThrowException(v8NormalString(m_isolate, "Debugging is not enabled."));
v8::Handle<v8::Value> argv[] = {
functionValue,
« no previous file with comments | « no previous file | Source/bindings/core/v8/ScriptValueSerializer.cpp » ('j') | Source/bindings/core/v8/V8Binding.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698