Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Unified Diff: tools/perf/measurements/memory.py

Issue 1027133002: Run GC after each memory test page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: revert unwanted change Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/memory.py
diff --git a/tools/perf/measurements/memory.py b/tools/perf/measurements/memory.py
index 3349f56a8240c4a5eb2fed379a749c97cea06501..812457073c38f3d1843fba5df12bf3a9d3b88479 100644
--- a/tools/perf/measurements/memory.py
+++ b/tools/perf/measurements/memory.py
@@ -22,6 +22,9 @@ class Memory(page_test.PageTest):
self._memory_metric.Start(page, tab)
self._power_metric.Start(page, tab)
+ def CleanUpAfterPage(self, page, tab):
+ tab.CollectGarbage()
haraken 2015/03/23 09:41:41 Just to confirm, but will this trigger enough numb
nednguyen 2015/03/24 01:21:14 What happen if the tab is already crashed here?
kouhei (in TOK) 2015/03/24 02:25:22 The line throws DevtoolsTargetCrashException and i
+
def CustomizeBrowserOptions(self, options):
memory.MemoryMetric.CustomizeBrowserOptions(options)
# Since this is a memory benchmark, we want to sample memory histograms at
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698