tools/perf/measurements/memory.py - Issue 1027133002: Run GC after each memory test page

Side by Side Diff: tools/perf/measurements/memory.py

Issue 1027133002: Run GC after each memory test page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: revert unwanted change Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | no next file » | no next file with comments »

OLD	NEW
1 # Copyright 2012 The Chromium Authors. All rights reserved.	1 # Copyright 2012 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 from metrics import memory	5 from metrics import memory

6 from metrics import power	6 from metrics import power

7 from telemetry.page import page_test	7 from telemetry.page import page_test

8	8

9 class Memory(page_test.PageTest):	9 class Memory(page_test.PageTest):

10 def __init__(self):	10 def __init__(self):

11 super(Memory, self).__init__()	11 super(Memory, self).__init__()

12 self._memory_metric = None	12 self._memory_metric = None

13 self._power_metric = None	13 self._power_metric = None

14	14

15 def WillStartBrowser(self, platform):	15 def WillStartBrowser(self, platform):

16 self._power_metric = power.PowerMetric(platform)	16 self._power_metric = power.PowerMetric(platform)

17	17

18 def DidStartBrowser(self, browser):	18 def DidStartBrowser(self, browser):

19 self._memory_metric = memory.MemoryMetric(browser)	19 self._memory_metric = memory.MemoryMetric(browser)

20	20

21 def DidNavigateToPage(self, page, tab):	21 def DidNavigateToPage(self, page, tab):

22 self._memory_metric.Start(page, tab)	22 self._memory_metric.Start(page, tab)

23 self._power_metric.Start(page, tab)	23 self._power_metric.Start(page, tab)

24	24

	25 def CleanUpAfterPage(self, page, tab):

	26 tab.CollectGarbage()
	haraken 2015/03/23 09:41:41 Just to confirm, but will this trigger enough numb Just to confirm, but will this trigger enough numbers of V8 & Oilpan GCs? nednguyen 2015/03/24 01:21:14 What happen if the tab is already crashed here? What happen if the tab is already crashed here? kouhei (in TOK) 2015/03/24 02:25:22 The line throws DevtoolsTargetCrashException and i Show quoted text On 2015/03/24 01:21:14, nednguyen wrote: > What happen if the tab is already crashed here? The line throws DevtoolsTargetCrashException and it goes to next test: _RunUserStoryAndProcessErrorIfNeeded at tools/telemetry/telemetry/user_story/user_story_runner.py:110 state.DidRunUserStory(results) DidRunUserStory at tools/telemetry/telemetry/page/shared_page_state.py:88 self._test.CleanUpAfterPage(self._current_page, self._current_tab) CleanUpAfterPage at tools/perf/measurements/memory.py:26 tab.CollectGarbage() CollectGarbage at tools/telemetry/telemetry/core/tab.py:232 self._inspector_backend.CollectGarbage() inner at tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py:40 inspector_backend._ConvertExceptionFromInspectorWebsocket(e) inner at tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py:37 return func(inspector_backend, args, *kwargs) CollectGarbage at tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py:317 self._page.CollectGarbage() CollectGarbage at tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_page.py:156 res = self._inspector_websocket.SyncRequest(request, timeout) SyncRequest at tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_websocket.py:100 self.SendAndIgnoreResponse(req) SendAndIgnoreResponse at tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_websocket.py:88 self._socket.send(data) send at tools/telemetry/third_party/websocket-client/websocket.py:567 l = self._send(data) _send at tools/telemetry/third_party/websocket-client/websocket.py:726 raise e DevtoolsTargetCrashException: Devtools target crashed
	27

25 def CustomizeBrowserOptions(self, options):	28 def CustomizeBrowserOptions(self, options):

26 memory.MemoryMetric.CustomizeBrowserOptions(options)	29 memory.MemoryMetric.CustomizeBrowserOptions(options)

27 # Since this is a memory benchmark, we want to sample memory histograms at	30 # Since this is a memory benchmark, we want to sample memory histograms at

28 # a high frequency.	31 # a high frequency.

29 options.AppendExtraBrowserArgs('--memory-metrics')	32 options.AppendExtraBrowserArgs('--memory-metrics')

30	33

31 def ValidateAndMeasurePage(self, page, tab, results):	34 def ValidateAndMeasurePage(self, page, tab, results):

32 self._power_metric.Stop(page, tab)	35 self._power_metric.Stop(page, tab)

33 self._memory_metric.Stop(page, tab)	36 self._memory_metric.Stop(page, tab)

34 self._memory_metric.AddResults(tab, results)	37 self._memory_metric.AddResults(tab, results)

35 self._power_metric.AddResults(tab, results)	38 self._power_metric.AddResults(tab, results)

OLD	NEW