Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1026983002: Allow adding an overlay not attached to the tab layer (Closed)

Created:
5 years, 9 months ago by aruslan
Modified:
5 years, 9 months ago
CC:
chromium-reviews, David Trainor- moved to gerrit, avayvod+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow adding an overlay not attached to the tab layer Currently any overlay ContentViewCore added to the Tab is automatically added to the Tab CC layer. This CL introduces a new parameter to allow romaing overlays. BUG=453121 Committed: https://crrev.com/8e2434c2327e15853b0709fb988a618afbc43b2f Cr-Commit-Position: refs/heads/master@{#322269}

Patch Set 1 #

Patch Set 2 : new parameter to attachOverlayContentViewCore instead of a new method. #

Patch Set 3 : attachToCC -> attachLayer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -7 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/Tab.java View 1 2 1 chunk +16 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/TransitionPageHelper.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/tab_android.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
aruslan
ptal thanks!
5 years, 9 months ago (2015-03-25 20:34:44 UTC) #2
David Trainor- moved to gerrit
lgtm
5 years, 9 months ago (2015-03-25 22:43:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1026983002/40001
5 years, 9 months ago (2015-03-25 23:26:55 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-26 00:13:58 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 00:15:01 UTC) #7
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/8e2434c2327e15853b0709fb988a618afbc43b2f
Cr-Commit-Position: refs/heads/master@{#322269}

Powered by Google App Engine
This is Rietveld 408576698