chrome/android/java/src/org/chromium/chrome/browser/tab/TransitionPageHelper.java - Issue 1026983002: Allow adding an overlay not attached to the tab layer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/TransitionPageHelper.java

Issue 1026983002: Allow adding an overlay not attached to the tab layer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: attachToCC -> attachLayer Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/TransitionPageHelper.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/TransitionPageHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/TransitionPageHelper.java

index 72f386687df8a16c5c6b30fb08a2d7610778177c..4f124de870a16482b7ed80f757dbedfd04b94421 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/TransitionPageHelper.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/TransitionPageHelper.java

@@ -612,7 +612,7 @@ public class TransitionPageHelper extends EmptyTabObserver {

mTransitionObserver = createTransitionObserver();

- if (mTab != null) mTab.attachOverlayContentViewCore(mTransitionContentViewCore, true);

+ if (mTab != null) mTab.attachOverlayContentViewCore(mTransitionContentViewCore, true, true);

nativeSetWebContents(mNativeTransitionPageHelperPtr, mTransitionContentViewCore);

setTransitionOpacity(0.0f);

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/Tab.java ('k') | chrome/browser/android/tab_android.cc » ('j') | no next file with comments »