Make common depend on app_mode_app_support.

Make common depend on app_mode_app_support.

This saves us from having to build app_mode_common.mm twice, and works
around an LTO bug on Mac.

BUG=469377
R=jam@chromium.org,jackhou@chromium.org

Committed: https://crrev.com/195da1f89da89ed9acb8808778a9ef7a62f3347a
Cr-Commit-Position: refs/heads/master@{#322209}

[jackhou1, 2015-03-22 23:31:16]

lgtm

https://codereview.chromium.org/1026833004/diff/1/chrome/chrome_common.gypi
File chrome/chrome_common.gypi (right):

https://codereview.chromium.org/1026833004/diff/1/chrome/chrome_common.gypi#n...
chrome/chrome_common.gypi:379: 'dependencies': [ 'app_mode_app_support' ],
I think you also need to add this to chrome/common/BUILD.gn:135.

[pcc1, 2015-03-23 19:36:24]

https://codereview.chromium.org/1026833004/diff/1/chrome/chrome_common.gypi
File chrome/chrome_common.gypi (right):

https://codereview.chromium.org/1026833004/diff/1/chrome/chrome_common.gypi#n...
chrome/chrome_common.gypi:379: 'dependencies': [ 'app_mode_app_support' ],
On 2015/03/22 23:31:15, jackhou1 wrote:
> I think you also need to add this to chrome/common/BUILD.gn:135.

Done.

[Nico, 2015-03-25 17:59:47]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2015-03-25 17:59:47]

lgtm

[Nico, 2015-03-25 17:59:52]

The CQ bit was checked by thakis@chromium.org

[Nico, 2015-03-25 17:59:52]

The patchset sent to the CQ was uploaded after l-g-t-m from jackhou@chromium.org
Link to the patchset: https://codereview.chromium.org/1026833004/#ps20001
(title: "Port to GN")

[commit-bot: I haz the power, 2015-03-25 18:01:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1026833004/20001

[Nico, 2015-03-25 18:02:03]

https://codereview.chromium.org/1026833004/diff/20001/chrome/common/BUILD.gn
File chrome/common/BUILD.gn (right):

https://codereview.chromium.org/1026833004/diff/20001/chrome/common/BUILD.gn#...
chrome/common/BUILD.gn:325: static_library("app_mode_app_support") {
(nit: i think gn uses source_set for most things instead of static_libraries.)

[commit-bot: I haz the power, 2015-03-25 19:23:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-25 19:24:39]

Patchset 2 (id:??) landed as
https://crrev.com/195da1f89da89ed9acb8808778a9ef7a62f3347a
Cr-Commit-Position: refs/heads/master@{#322209}