Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Side by Side Diff: chrome/common/BUILD.gn

Issue 1026833004: Make common depend on app_mode_app_support. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Port to GN Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/chrome_common.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//tools/grit/grit_rule.gni") 5 import("//tools/grit/grit_rule.gni")
6 6
7 gypi_values = exec_script("//build/gypi_to_gn.py", 7 gypi_values = exec_script("//build/gypi_to_gn.py",
8 [ rebase_path("../chrome_common.gypi") ], 8 [ rebase_path("../chrome_common.gypi") ],
9 "scope", 9 "scope",
10 [ "../chrome_common.gypi" ]) 10 [ "../chrome_common.gypi" ])
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 } else { 128 } else {
129 sources += 129 sources +=
130 rebase_path(gypi_values.chrome_common_networking_private_sources_nss, 130 rebase_path(gypi_values.chrome_common_networking_private_sources_nss,
131 ".", 131 ".",
132 "//chrome") 132 "//chrome")
133 } 133 }
134 } 134 }
135 if (is_mac) { 135 if (is_mac) {
136 sources += 136 sources +=
137 rebase_path(gypi_values.chrome_common_mac_sources, ".", "//chrome") 137 rebase_path(gypi_values.chrome_common_mac_sources, ".", "//chrome")
138 deps += [ ":app_mode_app_support" ]
138 } 139 }
139 140
140 if (enable_nacl) { 141 if (enable_nacl) {
141 deps += [ "//components/nacl:nacl_common" ] 142 deps += [ "//components/nacl:nacl_common" ]
142 } 143 }
143 144
144 # Printing. 145 # Printing.
145 if (enable_basic_printing || enable_print_preview) { 146 if (enable_basic_printing || enable_print_preview) {
146 deps += [ 147 deps += [
147 "//components/printing/common:printing_common", 148 "//components/printing/common:printing_common",
(...skipping 164 matching lines...) Expand 10 before | Expand all | Expand 10 after
312 313
313 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ] 314 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
314 315
315 if (enable_extensions) { 316 if (enable_extensions) {
316 sources += [ 317 sources += [
317 "extensions/extension_test_util.cc", 318 "extensions/extension_test_util.cc",
318 "extensions/extension_test_util.h", 319 "extensions/extension_test_util.h",
319 ] 320 ]
320 } 321 }
321 } 322 }
323
324 # GN version: chrome/chrome.gyp:app_mode_app_support
325 static_library("app_mode_app_support") {
Nico 2015/03/25 18:02:03 (nit: i think gn uses source_set for most things i
326 sources = [
327 "mac/app_mode_chrome_locator.h",
328 "mac/app_mode_chrome_locator.mm",
329 "mac/app_mode_common.h",
330 "mac/app_mode_common.mm",
331 ]
332
333 deps = [
334 ":constants",
335 "//base",
336 ]
337 }
OLDNEW
« no previous file with comments | « chrome/chrome_common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698